You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/07/18 21:08:19 UTC

[GitHub] [metron] mmiklavc commented on a change in pull request #1465: METRON-2172 Solr Updates Not Tested in Integration Test

mmiklavc commented on a change in pull request #1465: METRON-2172 Solr Updates Not Tested in Integration Test
URL: https://github.com/apache/metron/pull/1465#discussion_r305115702
 
 

 ##########
 File path: metron-platform/metron-solr/metron-solr-common/src/test/java/org/apache/metron/solr/dao/SolrSearchDaoTest.java
 ##########
 @@ -510,5 +512,13 @@ public void getGroupResultsShouldProperlyReturnGroupResults() {
     assertNull(level2GroupResults.get(1).getGroupResults());
   }
 
-
+  private SolrDocument createSolrDocument(String sensorType, Long timestamp) {
 
 Review comment:
   Thank you for this - simple types like this should not be mocked. Good improvement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services