[GitHub] [jackrabbit-filevault] tripodsan commented on pull request #162: JCRVLT-522 check effect of filter rules on ACLs

[GitBox <gi...@apache.org>]

tripodsan commented on pull request #162:
URL: https://github.com/apache/jackrabbit-filevault/pull/162#issuecomment-908628029


   > @tripodsan In general filter rules seem to be followed except for one edge case. What is the idea of `Importer.postFilter` (
   > 
   > https://github.com/apache/jackrabbit-filevault/blob/61e920f55e487aa5dc045c66ce5b7b5e444784ca/vault-core/src/main/java/org/apache/jackrabbit/vault/fs/io/Importer.java#L518
   > 
   > )? Is that supposed to filter out everything on an artifact level not contained in a filter and the DocViewSAXImporter only does the filtering on sub artifact level?
   
   I think it is used to find the TXInfo hierarchy that is covered by the filter.... maybe :-)
   
   > If so do you consider Importer.postFilter errorneous as it does not correctly filter out artifacts which are below a contained node (but excluded)?
   
   I don't think this will lead to errors. AFAIR, this is only the preliminary scan. the nodes are filtered again when traversing. but I might be wrong. it was a long time ago, when this code was created :-)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org