[GitHub] [hive] rbalamohan commented on a diff in pull request #3257: HIVE-26182: Some improvements to make DPP more debuggable

[GitBox <gi...@apache.org>]

rbalamohan commented on code in PR #3257:
URL: https://github.com/apache/hive/pull/3257#discussion_r861545546


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DynamicPartitionPruner.java:
##########
@@ -481,7 +482,9 @@ protected String processPayload(ByteBuffer payload, String sourceName) throws Se
             LOG.debug("Adding: {} to list of required partitions", value);
 
             info.values.add(value);
+            partitionCount++;
           }
+          LOG.info("Received {} partitions (source: {})", partitionCount, sourceName);

Review Comment:
   LGTM. +1.
   
   Minor comment before commit: It would be nice to include columnName in this line. (info.columnName). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org