[GitHub] [maven-common-artifact-filters] michael-o commented on a diff in pull request #29: [MSHARED-1104] Four element pattern may be GATV or GATC

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #29:
URL: https://github.com/apache/maven-common-artifact-filters/pull/29#discussion_r922818348


##########
src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java:
##########
@@ -481,15 +475,22 @@ else if ( ANY.equals( tokens[1] ) )
         }
     }
 
-    private static Pattern toPattern( final String token, final Coordinate coordinate )
+    private static Pattern toPattern( final String token, final Coordinate... coordinate )
+    {
+        return toPattern( token, token, coordinate );
+    }
+
+    private static Pattern toPattern( final String pattern, final String token, final Coordinate... coordinate )

Review Comment:
   coordinates



##########
src/main/java/org/apache/maven/shared/artifact/filter/PatternIncludesArtifactFilter.java:
##########
@@ -481,15 +475,22 @@ else if ( ANY.equals( tokens[1] ) )
         }
     }
 
-    private static Pattern toPattern( final String token, final Coordinate coordinate )
+    private static Pattern toPattern( final String token, final Coordinate... coordinate )

Review Comment:
   coordinates



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org