You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/07 08:30:25 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6952: ui: fix incorrect hypervisor in deploy VM wizard
shwstppr opened a new pull request, #6952:
URL: https://github.com/apache/cloudstack/pull/6952
### Description
Fixes #6756
Pass hypervisor parameter for `deployVirtualMachine` API only when ISO is selected and not for a template.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6952: ui: fix incorrect hypervisor on deploy VM wizard submit
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6952:
URL: https://github.com/apache/cloudstack/pull/6952#issuecomment-1340642489
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6952: ui: fix incorrect hypervisor on deploy VM wizard submit
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6952:
URL: https://github.com/apache/cloudstack/pull/6952#issuecomment-1340587928
@vladimirpetrov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6952: ui: fix incorrect hypervisor on deploy VM wizard submit
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6952:
URL: https://github.com/apache/cloudstack/pull/6952#issuecomment-1340867345
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6952?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6952](https://codecov.io/gh/apache/cloudstack/pull/6952?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70ebab5) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/d182eacf8622d3ef462b6ef56fb95b78028877b6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d182eac) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.17 #6952 +/- ##
=========================================
Coverage 10.34% 10.34%
Complexity 6612 6612
=========================================
Files 2451 2451
Lines 242356 242356
Branches 37926 37926
=========================================
Hits 25067 25067
Misses 214199 214199
Partials 3090 3090
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6952: ui: fix incorrect hypervisor on deploy VM wizard submit
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6952:
URL: https://github.com/apache/cloudstack/pull/6952#issuecomment-1340649847
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/6952 (QA-JID-12)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #6952: ui: fix incorrect hypervisor on deploy VM wizard submit
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on PR #6952:
URL: https://github.com/apache/cloudstack/pull/6952#issuecomment-1340587118
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6952: ui: fix incorrect hypervisor on deploy VM wizard submit
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6952:
URL: https://github.com/apache/cloudstack/pull/6952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6952: ui: fix incorrect hypervisor on deploy VM wizard submit
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6952:
URL: https://github.com/apache/cloudstack/pull/6952#issuecomment-1340665679
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6952: ui: fix incorrect hypervisor on deploy VM wizard submit
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6952:
URL: https://github.com/apache/cloudstack/pull/6952#issuecomment-1340642900
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org