You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/03/23 13:34:29 UTC
[GitHub] [shardingsphere] acmenlt opened a new pull request #16315: Fix expired links to optimize document format
acmenlt opened a new pull request #16315:
URL: https://github.com/apache/shardingsphere/pull/16315
Changes proposed in this pull request:
- Improve unreasonable formatting in documents
- Fix expired links
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zjcnb merged pull request #16315: Fix expired links to optimize document format
Posted by GitBox <gi...@apache.org>.
zjcnb merged pull request #16315:
URL: https://github.com/apache/shardingsphere/pull/16315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] acmenlt commented on a change in pull request #16315: Fix expired links to optimize document format
Posted by GitBox <gi...@apache.org>.
acmenlt commented on a change in pull request #16315:
URL: https://github.com/apache/shardingsphere/pull/16315#discussion_r833795262
##########
File path: docs/document/content/reference/test/integration-test/_index.cn.md
##########
@@ -99,19 +99,19 @@ SQL 用例在 `resources/cases/${SQL-TYPE}/${SQL-TYPE}-integration-test-cases.xm
目录：`src/test/resources/env/${SCENARIO-TYPE}`
- - `scenario-env.properties`: 数据源配置
- - `rules.yaml`: 规则配置
- - `databases.xml`: 真实库名称
- - `dataset.xml`: 初始化数据
- - `init-sql\${DATABASE-TYPE}\init.sql`: 初始化数据库表结构
- - `authority.xml`: 待补充
+ - `scenario-env.properties`: 数据源配置；
+ - `rules.yaml`: 规则配置；
+ - `databases.xml`: 真实库名称；
+ - `dataset.xml`: 初始化数据；
+ - `init-sql\${DATABASE-TYPE}\init.sql`: 初始化数据库表结构；；；
Review comment:
Yes, I'll correct it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #16315: Fix expired links to optimize document format
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #16315:
URL: https://github.com/apache/shardingsphere/pull/16315#discussion_r833495699
##########
File path: docs/document/content/reference/test/integration-test/_index.cn.md
##########
@@ -99,19 +99,19 @@ SQL 用例在 `resources/cases/${SQL-TYPE}/${SQL-TYPE}-integration-test-cases.xm
目录：`src/test/resources/env/${SCENARIO-TYPE}`
- - `scenario-env.properties`: 数据源配置
- - `rules.yaml`: 规则配置
- - `databases.xml`: 真实库名称
- - `dataset.xml`: 初始化数据
- - `init-sql\${DATABASE-TYPE}\init.sql`: 初始化数据库表结构
- - `authority.xml`: 待补充
+ - `scenario-env.properties`: 数据源配置；
+ - `rules.yaml`: 规则配置；
+ - `databases.xml`: 真实库名称；
+ - `dataset.xml`: 初始化数据；
+ - `init-sql\${DATABASE-TYPE}\init.sql`: 初始化数据库表结构；；；
Review comment:
There are 3 `；；；`, please remove duplicated one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #16315: Fix expired links to optimize document format
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #16315:
URL: https://github.com/apache/shardingsphere/pull/16315#issuecomment-1076759991
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16315?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16315](https://codecov.io/gh/apache/shardingsphere/pull/16315?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab43ceb) into [master](https://codecov.io/gh/apache/shardingsphere/commit/3958c811dd6e1c4729a86d741ef095d43bf1cdd4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3958c81) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #16315 +/- ##
============================================
- Coverage 60.76% 60.73% -0.04%
Complexity 2082 2082
============================================
Files 3304 3304
Lines 49791 49871 +80
Branches 8557 8569 +12
============================================
+ Hits 30257 30289 +32
- Misses 16989 17037 +48
Partials 2545 2545
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/16315?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...sharding/schedule/ShardingRuleAlteredDetector.java](https://codecov.io/gh/apache/shardingsphere/pull/16315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvc2NoZWR1bGUvU2hhcmRpbmdSdWxlQWx0ZXJlZERldGVjdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...e/ShardingRuleAlteredJobConfigurationPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/16315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvc2NoZWR1bGUvU2hhcmRpbmdSdWxlQWx0ZXJlZEpvYkNvbmZpZ3VyYXRpb25QcmVwYXJlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ore/job/environment/ScalingEnvironmentManager.java](https://codecov.io/gh/apache/shardingsphere/pull/16315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zY2FsaW5nL2NvcmUvam9iL2Vudmlyb25tZW50L1NjYWxpbmdFbnZpcm9ubWVudE1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ne/api/config/rulealtered/HandleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/16315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvYXBpL2NvbmZpZy9ydWxlYWx0ZXJlZC9IYW5kbGVDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../api/config/rulealtered/WorkflowConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/16315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLWRhdGEtcGlwZWxpbmUvc2hhcmRpbmdzcGhlcmUtZGF0YS1waXBlbGluZS1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGEvcGlwZWxpbmUvYXBpL2NvbmZpZy9ydWxlYWx0ZXJlZC9Xb3JrZmxvd0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../manager/NarayanaXATransactionManagerProvider.java](https://codecov.io/gh/apache/shardingsphere/pull/16315/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUta2VybmVsL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uL3NoYXJkaW5nc3BoZXJlLXRyYW5zYWN0aW9uLXR5cGUvc2hhcmRpbmdzcGhlcmUtdHJhbnNhY3Rpb24teGEvc2hhcmRpbmdzcGhlcmUtdHJhbnNhY3Rpb24teGEtcHJvdmlkZXIvc2hhcmRpbmdzcGhlcmUtdHJhbnNhY3Rpb24teGEtbmFyYXlhbmEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3RyYW5zYWN0aW9uL3hhL25hcmF5YW5hL21hbmFnZXIvTmFyYXlhbmFYQVRyYW5zYWN0aW9uTWFuYWdlclByb3ZpZGVyLmphdmE=) | `81.13% <0.00%> (+28.75%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16315?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/16315?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3958c81...ab43ceb](https://codecov.io/gh/apache/shardingsphere/pull/16315?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org