You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zhouyuan (via GitHub)" <gi...@apache.org> on 2026/09/24 12:02:56 UTC
[PR] [MINOR][VL] Refine ccache installation in dev script [gluten]
zhouyuan opened a new pull request, #13118:
URL: https://github.com/apache/gluten/pull/13118
<!--
Thank you for submitting a pull request! Here are some tips:
1. For first-time contributors, please read our contributing guide:
https://github.com/apache/gluten/blob/main/CONTRIBUTING.md
2. If necessary, create a GitHub issue for discussion beforehand to avoid duplicate work.
3. If the PR is specific to a single backend, include [VL] or [CH] in the PR title to indicate the
Velox or ClickHouse backend, respectively.
4. If the PR is not ready for review, please mark it as a draft.
-->
## What changes are proposed in this pull request?
unify the ccache version in CI
<!--
Provide a clear and concise description of the changes introduced in this PR.
Ensure the PR description aligns with the code changes, especially after updates.
If applicable, include "Fixes #<GitHub_Issue_ID>" to automatically close the corresponding issue
when the PR is merged.
-->
## How was this patch tested?
pass GHA
<!--
Describe how the changes were tested, if applicable.
Include new tests to validate the functionality, if necessary.
For UI-related changes, attach screenshots to demonstrate the updates.
-->
## Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [MINOR][VL] Refine ccache installation in dev script [gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan merged PR #13118:
URL: https://github.com/apache/gluten/pull/13118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [MINOR][VL] Refine ccache installation in dev script [gluten]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13118:
URL: https://github.com/apache/gluten/pull/13118#discussion_r4093384904
##########
dev/vcpkg/setup-build-depends.sh:
##########
@@ -172,18 +186,19 @@ install_centos_9() {
pip3 install --upgrade pip
-
dnf -y --enablerepo=crb install autoconf-archive ninja-build
+ install_ccache
Review Comment:
`install_centos_9` now calls `install_ccache`, whose implementation requires the `curl` executable, but this function's package list does not install curl. The CentOS 9 Docker path also starts from an image that only installs the distro ccache package, so this can fail with `curl: command not found`; add curl to the CentOS 9 prerequisites (or use the already-installed wget consistently).
##########
ep/build-velox/src/setup-openeuler24.sh:
##########
@@ -52,21 +52,32 @@ DUCKDB_VERSION="v0.8.1"
GEOS_VERSION="3.10.7"
ABSEIL_VERSION="20240116.2"
GRPC_VERSION="v1.48.1"
+CCACHE_VERSION="4.14"
function dnf_install {
dnf install -y -q --setopt=install_weak_deps=False "$@"
}
+function install_ccache {
+ # Static (musl) build: no glibc requirement, available for x86_64 and aarch64.
+ local name="ccache-${CCACHE_VERSION}-linux-$(uname -m)-musl-static"
+ curl -fsSL "https://github.com/ccache/ccache/releases/download/v${CCACHE_VERSION}/${name}.tar.gz" -o "/tmp/${name}.tar.gz"
+ tar -xzf "/tmp/${name}.tar.gz" -C /tmp
+ ${SUDO:-} install -m 0755 "/tmp/${name}/ccache" /usr/local/bin/ccache
+ rm -rf "/tmp/${name}" "/tmp/${name}.tar.gz"
+}
+
# Install packages required for build.
function install_build_prerequisites {
dnf update -y
- dnf_install dnf-plugins-core # For ccache, ninja
+ dnf_install dnf-plugins-core # For ninja
dnf update -y
- dnf_install ninja-build cmake ccache gcc g++ git wget which patch
+ dnf_install ninja-build cmake gcc g++ git wget which patch
Review Comment:
This new installer invokes `curl`, but the openEuler prerequisite list does not install it. On a minimal openEuler host, `install_build_prerequisites` will therefore abort at the next line with `curl: command not found`; add `curl` to this package list (or download with the already-installed `wget`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [MINOR][VL] Refine ccache installation in dev script [gluten]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #13118:
URL: https://github.com/apache/gluten/pull/13118#discussion_r4093433231
##########
dev/vcpkg/setup-build-depends.sh:
##########
@@ -19,10 +19,21 @@ set -e
## Install functions begin
+CCACHE_VERSION="4.14"
+
function semver {
echo "$@" | awk -F. '{ printf("%d%03d%03d", $1,$2,$3); }'
}
+install_ccache() {
+ # Static (musl) build: no glibc requirement, available for x86_64 and aarch64.
+ local name="ccache-${CCACHE_VERSION}-linux-$(uname -m)-musl-static"
Review Comment:
This helper is used by the generic vcpkg installer, while the repository still supports `ppc64le` (`dev/package.sh:28-31` and `ep/build-velox/src/build-velox.sh:205`). Because the static release is documented here as available only for x86_64/aarch64, `uname -m` becomes `ppc64le` and this constructs an unavailable download URL, regressing that platform from the distro ccache that was previously installed. Keep a package-manager fallback for unsupported architectures or reject them before replacing the package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [MINOR][VL] Refine ccache installation in dev script [gluten]
Posted by "prestodb-ci (via GitHub)" <gi...@apache.org>.
prestodb-ci commented on PR #13118:
URL: https://github.com/apache/gluten/pull/13118#issuecomment-5829444670
Kicking off rebase job, please wait...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org