You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by jukeks <gi...@git.apache.org> on 2017/10/10 09:43:25 UTC
[GitHub] incubator-guacamole-server pull request #116: GUACAMOLE-411: Fixed using uni...
GitHub user jukeks opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/116
GUACAMOLE-411: Fixed using uninitialized values in guacd_send_fd
Fixed valgrind's complaints when sending fds.
```
==8081== Thread 2:
==8081== Syscall param sendmsg(msg.msg_control) points to uninitialised byte(s)
==8081== at 0x505EA6D: ??? (syscall-template.S:84)
==8081== by 0x403F5C: guacd_send_fd (move-fd.c:61)
==8081== by 0x40390A: guacd_add_user (connection.c:196)
==8081== by 0x40390A: guacd_route_connection (connection.c:311)
==8081== by 0x40390A: guacd_connection_thread (connection.c:393)
==8081== by 0x50556B9: start_thread (pthread_create.c:333)
==8081== by 0x5A1F3DC: clone (clone.S:109)
==8081== Address 0xa558d54 is on thread 2's stack
==8081== in frame #1, created by guacd_send_fd (move-fd.c:34)
==8081== Uninitialised value was created by a stack allocation
==8081== at 0x403ED0: guacd_send_fd (move-fd.c:34)
==8081==
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jukeks/incubator-guacamole-server topic/GUACAMOLE-411
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #116
----
commit c8eaa91ad393a7d025e03f9eef94f7e046b16a69
Author: Jukka-Pekka Virtanen <ju...@ssh.com>
Date: 2017-10-10T09:41:19Z
GUACAMOLE-411: Fixed using uninitialized values in guacd_send_fd
----
---
[GitHub] incubator-guacamole-server pull request #116: GUACAMOLE-411: Fixed using uni...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-server/pull/116
---