You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@nemo.apache.org by GitBox <gi...@apache.org> on 2019/03/26 04:37:53 UTC

[GitHub] [incubator-nemo] sanha commented on a change in pull request #206: [NEMO-369] DirectByteArrayOutputStream usage refactoring

sanha commented on a change in pull request #206: [NEMO-369] DirectByteArrayOutputStream usage refactoring
URL: https://github.com/apache/incubator-nemo/pull/206#discussion_r268940881
 
 

 ##########
 File path: common/src/main/java/org/apache/nemo/common/DirectByteArrayOutputStream.java
 ##########
 @@ -42,16 +43,11 @@ public DirectByteArrayOutputStream(final int size) {
   }
 
   /**
+   * Note that serializedBytes include invalid bytes.
+   * So we have to use it with the actualLength whenever needed
 
 Review comment:
   How can the user know it's "actualLength"?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services