[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

[GitBox <gi...@apache.org>]

autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341414676
 
 

 ##########
 File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/materializer/HiveMaterializerFromEntityQueryGenerator.java
 ##########
 @@ -118,11 +119,19 @@ public QueryBasedHivePublishEntity generatePublishQueries() throws DataConversio
     Map<String, String> publishDirectories = publishEntity.getPublishDirectories();
     List<String> cleanupQueries = publishEntity.getCleanupQueries();
     List<String> cleanupDirectories = publishEntity.getCleanupDirectories();
+    Optional<Schema> avroSchema = Optional.absent();
 
 Review comment:
   You call. I am OK with both.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services