[GitHub] [arrow-datafusion] ovr commented on a diff in pull request #2196: feat: Support ArrayIndex for ScalarValue(List)

[GitBox <gi...@apache.org>]

ovr commented on code in PR #2196:
URL: https://github.com/apache/arrow-datafusion/pull/2196#discussion_r846837984


##########
datafusion/physical-expr/src/expressions/get_indexed_field.rs:
##########
@@ -105,9 +105,51 @@ impl PhysicalExpr for GetIndexedFieldExpr {
                 }
                 (dt, key) => Err(DataFusionError::NotImplemented(format!("get indexed field is only possible on lists with int64 indexes. Tried {} with {} index", dt, key))),
             },
-            ColumnarValue::Scalar(_) => Err(DataFusionError::NotImplemented(
-                "field access is not yet implemented for scalar values".to_string(),
-            )),
+            ColumnarValue::Scalar(scalar) => match (scalar.get_datatype(), &self.key) {
+                (DataType::List(v), ScalarValue::Int64(Some(i))) => {
+                    let wrapper = scalar.to_array();

Review Comment:
   Should I implement a new method that will convert Vec<SQLExpr> (which ScalarValue holds) for List instead of using the current API and temporarily ArrayRef? For example: `as_array_list()`?
   
   Thanks
   
   cC @alamb 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org