You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "msyavuz (via GitHub)" <gi...@apache.org> on 2025/06/25 12:22:58 UTC
[I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
msyavuz opened a new issue, #33908:
URL: https://github.com/apache/superset/issues/33908
### Bug description
When configuring dashboard filters with the "Values are dependent on other filters" option, the system prevents creating bi-directional dependencies upfront by showing a "Cyclic dependency detected" message. However, it allows creating the same dependency indirectly after saving the initial filter configuration.
1. If Filter A is set to depend on Filter B, the system blocks setting Filter B to depend on Filter A immediately, showing a "Cyclic dependency detected" message.
2. However, if Filter A is saved with the dependency on Filter B, the system later allows editing Filter B to create the reverse dependency, effectively forming a bi-directional (cyclic) dependency.
This behavior is inconsistent and might lead to unexpected filter behavior. It appears to contradict the intended prevention of cyclic dependencies.
How to reproduce the bug
1. Create a dashboard filter (e.g., Filter A) with a dependency on another filter (e.g., Filter B) by enabling the Values are dependent on other filters option.
2. Save the filter configuration.
3. Open the dashboard filter configuration again, select Filter B, and set it to depend on Filter A.
4. Save the changes.
## Expected results
The system should prevent bi-directional (cyclic) dependencies for all filter types, not just date filters. Users should not be able to create a cyclic dependency by editing the filters after saving the initial configuration.
## Actual results
The platform allows creating cyclic dependencies indirectly after the initial configuration, even though it prevents it upfront. This behavior is inconsistent and may lead to unexpected filter behavior.
### Screenshots/recordings
_No response_
### Superset version
master / latest-dev
### Python version
3.11
### Node version
18 or greater
### Browser
Chrome
### Additional context
_No response_
### Checklist
- [x] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [x] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "shahmeer888 (via GitHub)" <gi...@apache.org>.
shahmeer888 commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3090678242
@msyavuz I would like to work on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "naaa760 (via GitHub)" <gi...@apache.org>.
naaa760 commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3146304189
Hi @msyavuz !
I would like to work on this issue!
Please assign to me!
Thankyou!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3019097675
Hello @saiaika. Thanks for your contributions! To participate to the bounty program, please follow the [guidelines](https://preset.notion.site/preset-bounty-program-apache-superset). We assign individual issues to bounty program participants. You can definitely open fixes without being assigned to an issue but that won't qualify for the bounty. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3004980104
I expect this is closely related to https://github.com/apache/superset/issues/22979 and possibly related to https://github.com/apache/superset/issues/24511, if anyone sees a chance to fix multiple issues in the same part of the codebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "ngokturkkarli (via GitHub)" <gi...@apache.org>.
ngokturkkarli commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3338194920
@msyavuz Can i work on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "saiaika (via GitHub)" <gi...@apache.org>.
saiaika commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3015091178
Hi! I've submitted a fix for this issue: https://github.com/apache/superset/pull/33960
This addresses the cyclic dependency problem described in the issue. The fix prevents both immediate and indirect cyclic dependencies from being saved, with comprehensive test coverage.
Claiming the $150 bounty as specified in the issue description.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "tysoncung (via GitHub)" <gi...@apache.org>.
tysoncung commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3424585930
I'm interested in working on this issue. Could you provide more context about what you're looking for? Any additional details about requirements or constraints would be helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "developercoderreal (via GitHub)" <gi...@apache.org>.
developercoderreal commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3016482455
CC @dpgaspar @Vitor-Avila @mistercrunch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "Nandu9494 (via GitHub)" <gi...@apache.org>.
Nandu9494 commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3004805928
@geido I would like to take this, Please assign to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "saiaika (via GitHub)" <gi...@apache.org>.
saiaika commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3021344371
Hi @geido, if this issue hasn’t been assigned yet, I’d love to take it on. I’m currently learning, and even though I’m just starting, I’m committed to solving it and will work on it until it's resolved!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3004761436
---
### 🎉 **Preset Bounty Available: $150 USD** 🎉
To claim this bounty, please carefully follow the steps below.
---
#### 📋 **Steps to Participate**
1. **Review Guidelines:**
Read through the [Preset Bounty Program Contribution Guide](https://preset.notion.site/preset-bounty-program-apache-superset) for complete details on bounty requirements.
2. **Show Your Interest:**
Complete the [Preset Bounty Program Survey](https://docs.google.com/forms/d/e/1FAIpQLSeDsR1iWvPxFydUIXs2agsUg3kMDaAooeD4P9P1L5sI0Yu5QQ/viewform?usp=sharing) and comment this issue to express your interest.
3. **Join the Slack Channel:**
After completing the survey, you’ll receive an invitation to the dedicated [Apache Superset Slack](https://join.slack.com/t/apache-superset/shared_invite/zt-2be0drwz8-bxPfkdz28ozzk1Iox29ufg) channel.
4. **Get Assigned:**
To officially start, ensure a **Bounty Program Manager** has assigned you to this issue.
5. **Submit Your Solution:**
When ready, submit your solution with the `Fixes #{issue_number}` notation in your Pull Request description.
6. **Claim Your Bounty:**
Sign up at [GitPay.me](https://gitpay.me/) and submit your solution via: [https://gitpay.me/#/task/1217](https://gitpay.me/#/task/1217)
---
#### 💡 **Additional Notes**
- Only developers assigned by a **Bounty Program Manager** should start working on this issue to win the bounty.
- Be sure to follow the guide closely to avoid any delays in payment. Please, allow a few days after your PR has been merged for the bounty to be released.
Good luck, and happy coding! 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3425918046
@tysoncung There is already an ongoing work for this issue in https://github.com/apache/superset/pull/35317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "saiaika (via GitHub)" <gi...@apache.org>.
saiaika commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3015043972
This issue is still open?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "saiaika (via GitHub)" <gi...@apache.org>.
saiaika commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3015305331
@geido Fixes #33960 Please check-out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "ali0025 (via GitHub)" <gi...@apache.org>.
ali0025 commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3221547288
Hi @msyavuz, I’d like to work on this issue. Please assign me if it’s available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz closed issue #33908: Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters
URL: https://github.com/apache/superset/issues/33908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "saiaika (via GitHub)" <gi...@apache.org>.
saiaika commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3015084880
Hi! I've submitted a fix for this issue: [paste your PR link here]
This addresses the cyclic dependency problem described in the issue. The fix prevents both immediate and indirect cyclic dependencies from being saved, with comprehensive test coverage and proper user feedback.
Claiming the $150 bounty as specified in the issue description.
Technical summary:
- Added save-time validation in FiltersConfigModal.tsx handleSave method
- Blocks saving when cyclic dependencies are detected
- Includes comprehensive tests covering the exact scenario described in this issue
- Works for all filter types
- Maintains all existing functionality
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "LisaHusband (via GitHub)" <gi...@apache.org>.
LisaHusband commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3047921110
@geido If this issue hasn’t been assigned yet, I’d love to take it on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "shahmeer888 (via GitHub)" <gi...@apache.org>.
shahmeer888 commented on issue #33908:
URL: https://github.com/apache/superset/issues/33908#issuecomment-3152524624
> Hi [@msyavuz](https://github.com/msyavuz) ! I would like to work on this issue! Please assign to me! Thankyou!
I am actively working on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters [superset]
Posted by "msyavuz (via GitHub)" <gi...@apache.org>.
msyavuz closed issue #33908: Dashboard filters allow creating bi-directional dependencies in an unexpected way with value filters
URL: https://github.com/apache/superset/issues/33908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org