You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2012/05/30 17:43:23 UTC
[jira] [Created] (LUCENE-4090) PerFieldPostingsFormat cannot use
name as suffix
Robert Muir created LUCENE-4090:
-----------------------------------
Summary: PerFieldPostingsFormat cannot use name as suffix
Key: LUCENE-4090
URL: https://issues.apache.org/jira/browse/LUCENE-4090
Project: Lucene - Java
Issue Type: Bug
Components: core/index
Affects Versions: 4.0
Reporter: Robert Muir
Assignee: Robert Muir
Currently PFPF just records the name in the metadata, which matches up to the segment suffix. But this isnt enough, e.g. someone can use Pulsing(1) on one field and Pulsing(2) on another field.
See Mark Harwood's examples struggling with this on LUCENE-4069.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4090) PerFieldPostingsFormat cannot use
name as suffix
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285832#comment-13285832 ]
Michael McCandless commented on LUCENE-4090:
--------------------------------------------
Patch looks good! Nice having the per-field metadata...
I think it's fine to impl .equals() separately ... really getPostingsFormatPerField could work around that by holding a single instance of a given format and sharing that instance across fields.
> PerFieldPostingsFormat cannot use name as suffix
> ------------------------------------------------
>
> Key: LUCENE-4090
> URL: https://issues.apache.org/jira/browse/LUCENE-4090
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-4090.patch
>
>
> Currently PFPF just records the name in the metadata, which matches up to the segment suffix. But this isnt enough, e.g. someone can use Pulsing(1) on one field and Pulsing(2) on another field.
> See Mark Harwood's examples struggling with this on LUCENE-4069.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4090) PerFieldPostingsFormat cannot use
name as suffix
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285913#comment-13285913 ]
Robert Muir commented on LUCENE-4090:
-------------------------------------
Patch is still buggy, new one coming. My test was garbage basically and didnt detect the bug (since it inlines all terms).
At read time we have to key off the combined suffix too...
> PerFieldPostingsFormat cannot use name as suffix
> ------------------------------------------------
>
> Key: LUCENE-4090
> URL: https://issues.apache.org/jira/browse/LUCENE-4090
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-4090.patch
>
>
> Currently PFPF just records the name in the metadata, which matches up to the segment suffix. But this isnt enough, e.g. someone can use Pulsing(1) on one field and Pulsing(2) on another field.
> See Mark Harwood's examples struggling with this on LUCENE-4069.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4090) PerFieldPostingsFormat cannot use
name as suffix
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4090:
--------------------------------
Attachment: LUCENE-4090.patch
attached is a patch for trunk.
tests pass (obviously TestBackCompat fails, its a 4.0 index and we need to fix this there too before releasing).
I changed the IDHashMap to HashMap, but i didnt implement hashCode/equals on any postingsformats yet (though, i tested this on Lucene40PostingsFormat).
I think we should do that separately? its optional and a new optimization: today they all just implement Object.equals which means it works like it did before I broke it :)
> PerFieldPostingsFormat cannot use name as suffix
> ------------------------------------------------
>
> Key: LUCENE-4090
> URL: https://issues.apache.org/jira/browse/LUCENE-4090
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-4090.patch
>
>
> Currently PFPF just records the name in the metadata, which matches up to the segment suffix. But this isnt enough, e.g. someone can use Pulsing(1) on one field and Pulsing(2) on another field.
> See Mark Harwood's examples struggling with this on LUCENE-4069.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-4090) PerFieldPostingsFormat cannot use
name as suffix
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-4090.
---------------------------------
Resolution: Fixed
Fix Version/s: 5.0
4.0
Thanks for bringing this up Mark!
> PerFieldPostingsFormat cannot use name as suffix
> ------------------------------------------------
>
> Key: LUCENE-4090
> URL: https://issues.apache.org/jira/browse/LUCENE-4090
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4090.patch, LUCENE-4090.patch
>
>
> Currently PFPF just records the name in the metadata, which matches up to the segment suffix. But this isnt enough, e.g. someone can use Pulsing(1) on one field and Pulsing(2) on another field.
> See Mark Harwood's examples struggling with this on LUCENE-4069.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-4090) PerFieldPostingsFormat cannot use
name as suffix
Posted by "Mark Harwood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286411#comment-13286411 ]
Mark Harwood commented on LUCENE-4090:
--------------------------------------
Thanks for the quick fix, Rob :)
Working fine for me here now.
> PerFieldPostingsFormat cannot use name as suffix
> ------------------------------------------------
>
> Key: LUCENE-4090
> URL: https://issues.apache.org/jira/browse/LUCENE-4090
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Fix For: 4.0, 5.0
>
> Attachments: LUCENE-4090.patch, LUCENE-4090.patch
>
>
> Currently PFPF just records the name in the metadata, which matches up to the segment suffix. But this isnt enough, e.g. someone can use Pulsing(1) on one field and Pulsing(2) on another field.
> See Mark Harwood's examples struggling with this on LUCENE-4069.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-4090) PerFieldPostingsFormat cannot use
name as suffix
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-4090:
--------------------------------
Attachment: LUCENE-4090.patch
updated patch. I beefed up randomcodec to add Memory(false) and Memory(true) and also 2 (usually) different configurations of Pulsing.
I also fixed the test to be less trivial, so all terms dont have a ttf=1, and i turned on term vectors to get the cross-check explicitly.
I think this one is ready to go.
> PerFieldPostingsFormat cannot use name as suffix
> ------------------------------------------------
>
> Key: LUCENE-4090
> URL: https://issues.apache.org/jira/browse/LUCENE-4090
> Project: Lucene - Java
> Issue Type: Bug
> Components: core/index
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-4090.patch, LUCENE-4090.patch
>
>
> Currently PFPF just records the name in the metadata, which matches up to the segment suffix. But this isnt enough, e.g. someone can use Pulsing(1) on one field and Pulsing(2) on another field.
> See Mark Harwood's examples struggling with this on LUCENE-4069.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org