You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Karel Kolman (Jira)" <ji...@apache.org> on 2020/01/21 12:26:00 UTC
[jira] [Comment Edited] (HADOOP-16822) Provide source artifacts for
hadoop-client-api
[ https://issues.apache.org/jira/browse/HADOOP-16822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020180#comment-17020180 ]
Karel Kolman edited comment on HADOOP-16822 at 1/21/20 12:25 PM:
-----------------------------------------------------------------
Attaching a proposed patch to generate aggregate source jar for hadoop-client-api.
The patch sets two *maven-shade-plugin* options
- createSourcesJar=true
- shadeSourcesContent=true
Previously there had been a case of char missing in "createSourcesJar" solved in HADOOP-13989 (createSourcesJar vs createSourceJar - plural vs singular)
The latter settings performs an advanced source shading, not only moving java files to shaded folders, but also relocating imports in source files (that is my understanding).
Not a requirement, just nice to have.
Similar patch if accepted can be easily applied to the other shaded artifacts.
was (Author: karel.kolman):
Attaching a proposed patch to generate aggregate source jar for hadoop-client-api.
The patch sets two *maven-shade-plugin* options
- createSourcesJar=true
- shadeSourcesContent=true
Previously there had been a case of char missing in "createSourcesJar" solved in HADOOP-13989 (createSourcesJar vs createSourceJar - plural vs singular)
The latter settings performs an advanced source shading, not only moving java files to shaded folders, but also relocating imports in source files (that is my understanding).
Similar patch if accepted can be easily applied to the other shaded artifacts.
> Provide source artifacts for hadoop-client-api
> ----------------------------------------------
>
> Key: HADOOP-16822
> URL: https://issues.apache.org/jira/browse/HADOOP-16822
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Karel Kolman
> Priority: Major
> Attachments: HADOOP-16822-hadoop-client-api-source-jar.patch
>
>
> h5. Improvement request
> The third-party libraries shading hadoop-client-api (& hadoop-client-runtime) artifacts are super useful.
>
> Having uber source jar for hadoop-client-api (maybe even hadoop-client-runtime) would be great for downstream development & debugging purposes.
> Are there any obstacles or objections against providing fat jar with all the hadoop client api as well ?
> h5. Dev links
> - *maven-shaded-plugin* and its *shadeSourcesContent* attribute
> - https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#shadeSourcesContent
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org