[jira] [Commented] (FLINK-8553) switch flink-metrics-datadog to async mode

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354788#comment-16354788 ] 

ASF GitHub Bot commented on FLINK-8553:
---------------------------------------

GitHub user bowenli86 opened a pull request:

    https://github.com/apache/flink/pull/5418

    [FLINK-8553] switch flink-metrics-datadog to async mode

    ## What is the purpose of the change
    
    Currently DatadogHttpClient in flink-metrics-datadog send http request synchronously. It takes up to 3 sec depending on the network condition, and may slow Flink down.
    
    Switching DatadogHttpClient to async mode.
    
    Some benchmarking with averages from 20 rounds:
    - with 20 metrics, async took 2 millisec and sync took 150 millisec
    - with 200 metrics, async took 5 millisec and sync took 295 millisec
    
    So switching to async will improve the perf by about 50-70X 
    
    ## Brief change log
    
    Switching DatadogHttpClient to async mode.
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
    none
    
    ## Documentation
    
    none

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bowenli86/flink FLINK-8553

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5418.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5418
    
----
commit 19c48d78702329687584295c0370434318527445
Author: Bowen Li <bo...@...>
Date:   2018-02-07T00:11:18Z

    [FLINK-8553] switch flink-metrics-datadog to async mode

----


> switch flink-metrics-datadog to async mode
> ------------------------------------------
>
>                 Key: FLINK-8553
>                 URL: https://issues.apache.org/jira/browse/FLINK-8553
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.4.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>            Priority: Major
>             Fix For: 1.5.0
>
>
> Even though currently flink-metrics-datadog is designed as `fire-and-forget`, it's still using sync calls which may block or slow down core. Need to switch it to async mode.
> cc  [~Zentol]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)