[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #315: Add conditions for Azure specific tasks

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #315: Add conditions for Azure specific tasks
URL: https://github.com/apache/fluo-muchos/pull/315#discussion_r372166170
 
 

 ##########
 File path: ansible/accumulo.yml
 ##########
 @@ -30,11 +30,11 @@
 - hosts: all:!{{ azure_proxy_host }}
   tasks:
     - import_tasks: roles/accumulo/tasks/add-adlsgen2.yml
-      when: accumulo_major_version == '2' and use_adlsg2 == True
+      when: cluster_type == 'azure' and accumulo_major_version == '2' and use_adlsg2 == True
 
 Review comment:
   `use_adlsg2 == True` still feels a bit redundant to me. It seems likely that just `use_adlsg2` would work, but I haven't tried it (same comment for the other occurrences of this also):
   
   ```suggestion
         when: cluster_type == 'azure' and accumulo_major_version == '2' and use_adlsg2
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services