You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "morrySnow (via GitHub)" <gi...@apache.org> on 2024/01/15 06:43:50 UTC
[PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
morrySnow opened a new pull request, #29976:
URL: https://github.com/apache/doris/pull/29976
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29976:
URL: https://github.com/apache/doris/pull/29976#issuecomment-1893048647
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29976:
URL: https://github.com/apache/doris/pull/29976#issuecomment-1893048627
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29976:
URL: https://github.com/apache/doris/pull/29976#issuecomment-1892051769
<details>
<summary>TPC-H: <b>Total hot run time: 39773 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f6f06e5b5b5895668efc019fbe2a06511d5c34e3, data reload: false
------ Round 1 ----------------------------------
q1 19368 6897 5843 5843
q2 2387 167 164 164
q3 12611 1158 1206 1158
q4 10848 808 820 808
q5 8015 3243 3118 3118
q6 208 125 126 125
q7 921 494 487 487
q8 9277 1968 1993 1968
q9 7290 6451 6398 6398
q10 8186 3053 3100 3053
q11 415 206 213 206
q12 369 196 197 196
q13 18121 3414 3411 3411
q14 242 222 228 222
q15 556 522 517 517
q16 433 384 383 383
q17 945 473 473 473
q18 7696 6958 6913 6913
q19 4244 1336 1350 1336
q20 535 314 304 304
q21 2953 2374 2491 2374
q22 367 340 316 316
Total cold run time: 115987 ms
Total hot run time: 39773 ms
----- Round 2, with runtime_filter_mode=off -----
q1 5802 5711 5547 5547
q2 348 229 223 223
q3 3351 3163 3153 3153
q4 2251 1945 2149 1945
q5 6170 6011 5860 5860
q6 208 123 118 118
q7 2378 1981 1934 1934
q8 3623 3738 3720 3720
q9 9728 23091 9529 9529
q10 11790 3806 3800 3800
q11 670 466 468 466
q12 1625 660 617 617
q13 17353 3265 3234 3234
q14 303 259 263 259
q15 573 521 515 515
q16 577 480 498 480
q17 9445 2041 1970 1970
q18 9448 9618 10762 9618
q19 16081 1675 1609 1609
q20 3701 1953 1923 1923
q21 15259 5873 5840 5840
q22 751 608 599 599
Total cold run time: 121435 ms
Total hot run time: 62959 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29976:
URL: https://github.com/apache/doris/pull/29976#issuecomment-1892085287
<details>
<summary>ClickBench: <b>Total hot run time: 31.48 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f6f06e5b5b5895668efc019fbe2a06511d5c34e3, data reload: false
query1 0.06 0.06 0.06
query2 0.05 0.02 0.03
query3 0.26 0.13 0.11
query4 1.77 0.12 0.12
query5 0.54 0.53 0.53
query6 1.32 0.65 0.64
query7 0.02 0.02 0.01
query8 0.03 0.02 0.03
query9 0.55 0.52 0.50
query10 0.57 0.58 0.56
query11 0.13 0.09 0.09
query12 0.11 0.09 0.09
query13 0.61 0.60 0.60
query14 0.78 0.78 0.80
query15 0.79 0.78 0.78
query16 0.37 0.39 0.38
query17 1.02 1.02 1.01
query18 0.25 0.25 0.26
query19 1.88 1.77 1.74
query20 0.01 0.01 0.01
query21 15.43 0.57 0.55
query22 2.64 2.49 2.14
query23 17.41 0.80 0.88
query24 2.63 1.09 1.06
query25 0.34 0.28 0.15
query26 0.58 0.14 0.14
query27 0.06 0.07 0.05
query28 11.33 0.83 0.78
query29 12.62 3.25 3.11
query30 0.58 0.54 0.55
query31 2.77 0.36 0.36
query32 3.37 0.49 0.49
query33 3.20 3.23 3.25
query34 15.98 4.26 4.22
query35 4.36 4.29 4.23
query36 1.11 1.08 1.09
query37 0.06 0.05 0.05
query38 0.04 0.02 0.02
query39 0.02 0.01 0.01
query40 0.16 0.13 0.13
query41 0.08 0.01 0.02
query42 0.02 0.02 0.01
query43 0.03 0.02 0.02
Total cold run time: 105.94 s
Total hot run time: 31.48 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #29976:
URL: https://github.com/apache/doris/pull/29976#issuecomment-1891996756
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29976:
URL: https://github.com/apache/doris/pull/29976#issuecomment-1892090976
Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
```
Load test result on commit f6f06e5b5b5895668efc019fbe2a06511d5c34e3 with default session variables
Stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc: 58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select: 14.7 seconds inserted 10000000 Rows, about 680K ops/s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow merged PR #29976:
URL: https://github.com/apache/doris/pull/29976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29976:
URL: https://github.com/apache/doris/pull/29976#issuecomment-1892073683
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.96 seconds
stream load tsv: 561 seconds loaded 74807831229 Bytes, about 127 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 21.3 seconds inserted 10000000 Rows, about 469K ops/s
storage size: 17183836299 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29976:
URL: https://github.com/apache/doris/pull/29976#issuecomment-1892072590
<details>
<summary>TPC-DS: <b>Total hot run time: 178306 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f6f06e5b5b5895668efc019fbe2a06511d5c34e3, data reload: false
query1 932 341 330 330
query2 6713 1832 1823 1823
query3 6719 203 204 203
query4 33236 22218 22130 22130
query5 6944 578 515 515
query6 254 175 190 175
query7 4619 275 276 275
query8 232 188 196 188
query9 9193 2697 2875 2697
query10 459 248 253 248
query11 16801 15410 15359 15359
query12 129 74 71 71
query13 1704 396 380 380
query14 11197 7312 7342 7312
query15 213 185 185 185
query16 4637 257 243 243
query17 1007 487 486 486
query18 1809 272 264 264
query19 179 150 142 142
query20 77 78 71 71
query21 191 130 130 130
query22 4980 4775 4657 4657
query23 31953 30988 30940 30940
query24 12763 2841 2786 2786
query25 579 328 321 321
query26 1879 146 154 146
query27 3393 275 275 275
query28 7284 1878 1853 1853
query29 2203 696 685 685
query30 285 140 146 140
query31 957 761 778 761
query32 81 59 60 59
query33 729 249 239 239
query34 1350 470 470 470
query35 884 777 743 743
query36 1426 1282 1299 1282
query37 182 68 76 68
query38 3397 3279 3290 3279
query39 1329 1279 1262 1262
query40 340 98 95 95
query41 40 36 38 36
query42 110 89 94 89
query43 536 527 506 506
query44 1050 706 710 706
query45 202 187 182 182
query46 1065 630 619 619
query47 1702 1582 1519 1519
query48 398 325 336 325
query49 1242 330 301 301
query50 715 309 324 309
query51 5396 5214 5217 5214
query52 108 96 84 84
query53 357 284 294 284
query54 897 454 464 454
query55 90 87 90 87
query56 212 196 187 187
query57 993 899 960 899
query58 214 192 198 192
query59 2897 2609 2602 2602
query60 248 231 228 228
query61 83 84 83 83
query62 665 415 409 409
query63 303 291 299 291
query64 6271 1655 1623 1623
query65 3362 3259 3264 3259
query66 1454 345 338 338
query67 15654 14872 15222 14872
query68 10011 492 519 492
query69 649 335 343 335
query70 1748 1559 1586 1559
query71 540 243 237 237
query72 4471 2848 2847 2847
query73 1915 317 308 308
query74 7148 6410 6538 6410
query75 4833 2289 2331 2289
query76 6218 1022 981 981
query77 822 264 267 264
query78 9360 8866 8766 8766
query79 1014 517 508 508
query80 697 345 352 345
query81 458 208 213 208
query82 234 89 99 89
query83 172 127 118 118
query84 284 75 73 73
query85 1075 340 332 332
query86 403 407 378 378
query87 3588 3380 3365 3365
query88 2805 2216 2215 2215
query89 456 403 370 370
query90 2077 211 190 190
query91 153 128 126 126
query92 58 56 54 54
query93 992 431 435 431
query94 1146 191 175 175
query95 524 489 479 479
query96 622 324 313 313
query97 4320 4188 4180 4180
query98 202 188 183 183
query99 1004 700 748 700
Total cold run time: 299502 ms
Total hot run time: 178306 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](Nereids) should not fold constant when do ordinal group by [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #29976:
URL: https://github.com/apache/doris/pull/29976#issuecomment-1891396481
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org