You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2025/07/05 18:24:30 UTC
Change in asterixdb[master]: [NO ISSUE][*DB][TEST] Minor test framework fixes
From Michael Blow <mb...@apache.org>:
Michael Blow has uploaded this change for review. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20023 )
Change subject: [NO ISSUE][*DB][TEST] Minor test framework fixes
......................................................................
[NO ISSUE][*DB][TEST] Minor test framework fixes
Ext-ref: MB-65861
Change-Id: I5cad75b8263f8461a73405531beeb056254ae47e
---
M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
1 file changed, 18 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/23/20023/1
diff --git a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
index f9d0efb..8d943bf 100644
--- a/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
+++ b/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
@@ -2254,16 +2254,22 @@
}
fail(true, testCaseCtx, cUnit, testFileCtxs, pb, testFile, e);
} else {
- LOGGER.info("testFile {} raised an (expected) exception", testFile, e.toString());
+ LOGGER.info("testFile {} raised an (expected) exception: {}", testFile, e.toString());
}
}
if (numOfFiles == testFileCtxs.size()) {
- if (testCaseCtx.numOfErrors < cUnit.getExpectedError().size()) {
+ int numExpectedErrors = cUnit.getExpectedError().size();
+ if (testCaseCtx.numOfErrors < numExpectedErrors) {
LOGGER.error("Test {} failed to raise (an) expected exception(s)", cUnit.getName());
throw new Exception(
"Test \"" + cUnit.getName() + "\" FAILED; expected exception was not thrown...");
}
ensureWarnings(testCaseCtx.expectedWarnings, cUnit);
+ if (testCaseCtx.numOfErrors > numExpectedErrors) {
+ LOGGER.error("Test {} raised more exceptions than expected", cUnit.getName());
+ throw new Exception(
+ "Test \"" + cUnit.getName() + "\" FAILED; too many exceptions were thrown...");
+ }
LOGGER.info(
"[TEST]: " + testCaseCtx.getTestCase().getFilePath() + "/" + cUnit.getName() + " PASSED ");
if (passedGroup != null) {
--
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/20023
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: I5cad75b8263f8461a73405531beeb056254ae47e
Gerrit-Change-Number: 20023
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Blow <mb...@apache.org>
Gerrit-MessageType: newchange