You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/08/14 21:46:19 UTC
Review Request 71291: Refactored (un)trackReservations() in the
allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71291/
-----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
Repository: mesos
Description
-------
Refactored (un)trackReservations() in the allocator.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 8be8dcee04e8fc5b97f730b2f058d14c81678788
src/master/allocator/mesos/hierarchical.cpp 580d35a3b71c1f7e851fa0504c6b9f037c05c378
Diff: https://reviews.apache.org/r/71291/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 71291: Refactored (un)trackReservations() in the
allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71291/#review217233
-----------------------------------------------------------
Bad review!
Reviews applied: [71291, 71269, 71258, 71257, 71255, 71254]
Error:
2019-08-16 04:23:48 URL:https://reviews.apache.org/r/71254/diff/raw/ [5967/5967] -> "71254.patch" [1]
error: patch failed: src/master/allocator/mesos/sorter/drf/sorter.cpp:17
error: src/master/allocator/mesos/sorter/drf/sorter.cpp: patch does not apply
error: patch failed: src/master/allocator/mesos/sorter/random/sorter.cpp:17
error: src/master/allocator/mesos/sorter/random/sorter.cpp: patch does not apply
- Mesos Reviewbot
On Aug. 14, 2019, 2:46 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71291/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 2:46 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored (un)trackReservations() in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 8be8dcee04e8fc5b97f730b2f058d14c81678788
> src/master/allocator/mesos/hierarchical.cpp 580d35a3b71c1f7e851fa0504c6b9f037c05c378
>
>
> Diff: https://reviews.apache.org/r/71291/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71291: Refactored (un)trackReservations() in the
allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71291/#review217219
-----------------------------------------------------------
Ship it!
- Benjamin Mahler
On Aug. 14, 2019, 9:46 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71291/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 9:46 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored (un)trackReservations() in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 8be8dcee04e8fc5b97f730b2f058d14c81678788
> src/master/allocator/mesos/hierarchical.cpp 580d35a3b71c1f7e851fa0504c6b9f037c05c378
>
>
> Diff: https://reviews.apache.org/r/71291/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71291: Refactored (un)trackReservations() in the
allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71291/#review217213
-----------------------------------------------------------
Bad review!
Reviews applied: [71291, 71269, 71258, 71257, 71255, 71254]
Error:
2019-08-14 23:18:59 URL:https://reviews.apache.org/r/71254/diff/raw/ [5967/5967] -> "71254.patch" [1]
error: patch failed: src/master/allocator/mesos/sorter/drf/sorter.cpp:17
error: src/master/allocator/mesos/sorter/drf/sorter.cpp: patch does not apply
error: patch failed: src/master/allocator/mesos/sorter/random/sorter.cpp:17
error: src/master/allocator/mesos/sorter/random/sorter.cpp: patch does not apply
- Mesos Reviewbot
On Aug. 14, 2019, 9:46 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71291/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 9:46 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored (un)trackReservations() in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 8be8dcee04e8fc5b97f730b2f058d14c81678788
> src/master/allocator/mesos/hierarchical.cpp 580d35a3b71c1f7e851fa0504c6b9f037c05c378
>
>
> Diff: https://reviews.apache.org/r/71291/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 71291: Refactored (un)trackReservations() in the
allocator.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71291/#review217249
-----------------------------------------------------------
Bad review!
Reviews applied: [71291, 71269, 71258, 71257, 71255, 71254]
Error:
2019-08-16 21:31:33 URL:https://reviews.apache.org/r/71254/diff/raw/ [5967/5967] -> "71254.patch" [1]
error: patch failed: src/master/allocator/mesos/sorter/drf/sorter.cpp:17
error: src/master/allocator/mesos/sorter/drf/sorter.cpp: patch does not apply
error: patch failed: src/master/allocator/mesos/sorter/random/sorter.cpp:17
error: src/master/allocator/mesos/sorter/random/sorter.cpp: patch does not apply
- Mesos Reviewbot
On Aug. 14, 2019, 2:46 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71291/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2019, 2:46 p.m.)
>
>
> Review request for mesos, Andrei Sekretenko and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Refactored (un)trackReservations() in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 8be8dcee04e8fc5b97f730b2f058d14c81678788
> src/master/allocator/mesos/hierarchical.cpp 580d35a3b71c1f7e851fa0504c6b9f037c05c378
>
>
> Diff: https://reviews.apache.org/r/71291/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>