[GitHub] spark pull request: [SPARK-6773][Tests]Fix RAT checks still passed...

[srowen <gi...@git.apache.org>]

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5421#discussion_r27989912
  
    --- Diff: dev/check-license ---
    @@ -71,6 +72,11 @@ mkdir -p "$FWDIR"/lib
     
     $java_cmd -jar "$rat_jar" -E "$FWDIR"/.rat-excludes  -d "$FWDIR" > rat-results.txt
     
    +if [ $? -ne 0 ]; then
    +   echo "Error happen when running rat, pls checking the rat jar"
    --- End diff --
    
    This seems fine except that this message needs improvement. 'RAT exited abnormally' is probably fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org