[GitHub] [ignite-3] rpuch commented on a diff in pull request #2168: IGNITE-19685 Treat Scalecube's LEAVING event as 'node left' in the physical topology

["rpuch (via GitHub)" <gi...@apache.org>]

rpuch commented on code in PR #2168:
URL: https://github.com/apache/ignite-3/pull/2168#discussion_r1223097131


##########
modules/runner/src/integrationTest/java/org/apache/ignite/internal/Cluster.java:
##########
@@ -135,12 +135,28 @@ public void startAndInit(int nodeCount) {
      * @param initParametersConfigurator Configure {@link InitParameters} before initializing the cluster.
      */
     public void startAndInit(int nodeCount, Consumer<InitParametersBuilder> initParametersConfigurator) {
+        startAndInit(nodeCount, defaultNodeBootstrapConfigTemplate, initParametersConfigurator);
+    }
+
+    /**
+     * Starts the cluster with the given number of nodes and initializes it.
+     *
+     * @param nodeCount Number of nodes in the cluster.
+     * @param nodeBootstrapConfigTemplate Node bootstrap config template to be used for each node started
+     *     with this call.
+     * @param initParametersConfigurator Configure {@link InitParameters} before initializing the cluster.
+     */
+    public void startAndInit(
+            int nodeCount,
+            String nodeBootstrapConfigTemplate,

Review Comment:
   Why? Usually it is more convenient to have 'closure-like' arguments last in the arg list



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org