[GitHub] [incubator-druid] gianm commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #8864: add sequenceName and currentCheckPoint for backwards compatibility
URL: https://github.com/apache/incubator-druid/pull/8864#discussion_r347704437
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/common/actions/CheckPointDataSourceMetadataAction.java
 ##########
 @@ -68,13 +69,32 @@ public Integer getTaskGroupId()
   }
 
   // For backwards compatibility
-  @Deprecated
   @JsonProperty
-  public SeekableStreamDataSourceMetadata getPreviousCheckPoint()
+  private SeekableStreamDataSourceMetadata getPreviousCheckPoint()
   {
     return checkpointMetadata;
   }
 
+  // For backwards compatibility
+  @JsonProperty
+  private SeekableStreamDataSourceMetadata getCurrentCheckPoint()
+  {
+    return checkpointMetadata;
+  }
+
+  /**
+   * Returning a dummy value so the objects from older versions still work
 
 Review comment:
   How would returning a dummy value make objects from older versions work with the current version? Modifying the serialization code now won't change what older versions do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org