You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/02/21 12:36:19 UTC
[GitHub] [fineract] galovics opened a new pull request #2044: FINERACT-984: More database independence in queries
galovics opened a new pull request #2044:
URL: https://github.com/apache/fineract/pull/2044
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #2044: FINERACT-984: More database independence in queries
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #2044:
URL: https://github.com/apache/fineract/pull/2044#discussion_r811349981
##########
File path: fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java
##########
@@ -171,17 +171,17 @@ public InteropServiceImpl(PlatformSecurityContext securityContext, InteropDataVa
private static final class KycMapper implements RowMapper<InteropKycData> {
public String schema() {
- return " country.code_value as nationality, c.`date_of_birth` as dateOfBirth, c.`mobile_no` as contactPhone, gender.code_value as gender, c.`email_address` as email, "
- + "kyc.code_value as idType, ci.`document_key` as idNo, ci.`description` as description, "
+ return " country.code_value as nationality, c.date_of_birth as dateOfBirth, c.mobile_no as contactPhone, gender.code_value as gender, c.email_address as email, "
+ + "kyc.code_value as idType, ci.document_key as idNo, ci.`description` as description, "
Review comment:
@galovics any reason why these backticks are still here? Shouldn't they be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2044: FINERACT-984: More database independence in queries
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #2044:
URL: https://github.com/apache/fineract/pull/2044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a change in pull request #2044: FINERACT-984: More database independence in queries
Posted by GitBox <gi...@apache.org>.
galovics commented on a change in pull request #2044:
URL: https://github.com/apache/fineract/pull/2044#discussion_r811350411
##########
File path: fineract-provider/src/main/java/org/apache/fineract/interoperation/service/InteropServiceImpl.java
##########
@@ -171,17 +171,17 @@ public InteropServiceImpl(PlatformSecurityContext securityContext, InteropDataVa
private static final class KycMapper implements RowMapper<InteropKycData> {
public String schema() {
- return " country.code_value as nationality, c.`date_of_birth` as dateOfBirth, c.`mobile_no` as contactPhone, gender.code_value as gender, c.`email_address` as email, "
- + "kyc.code_value as idType, ci.`document_key` as idNo, ci.`description` as description, "
+ return " country.code_value as nationality, c.date_of_birth as dateOfBirth, c.mobile_no as contactPhone, gender.code_value as gender, c.email_address as email, "
+ + "kyc.code_value as idType, ci.document_key as idNo, ci.`description` as description, "
Review comment:
@vidakovic they will be removed in an upcoming PR, not forgotten but good job spotting it ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org