You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/29 14:58:39 UTC
[GitHub] [incubator-doris] qzsee opened a new pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
qzsee opened a new pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526
## Proposed changes
fix #6525
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #6525) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-909935262
This bug has been fixed in new version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] qzsee commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
qzsee commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910058088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] qzsee edited a comment on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
qzsee edited a comment on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910064230
> ```c++
> Status ExprContext::prepare(RuntimeState* state, const RowDescriptor& row_desc,
> const std::shared_ptr<MemTracker>& tracker) {
> _prepared = true;
> ...
> }
>
> Status ExprContext::open(RuntimeState* state) {
> DCHECK(_prepared);
> ...
> }
> ```
>
> Maybe you can refer to the `ExprContext` method to avoid repeatedly calling prepare by mistake?
The prepare method is normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-913371527
this has been fixed in new version of runtime filter, you can refer to #6077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-909937505
```cpp
Status ExprContext::prepare(RuntimeState* state, const RowDescriptor& row_desc,
const std::shared_ptr<MemTracker>& tracker) {
_prepared = true;
...
}
Status ExprContext::open(RuntimeState* state) {
DCHECK(_prepared);
...
}
```
Maybe you can refer to the `ExprContext` method to avoid repeatedly calling prepare by mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] qzsee edited a comment on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
qzsee edited a comment on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910064230
> ```c++
> Status ExprContext::prepare(RuntimeState* state, const RowDescriptor& row_desc,
> const std::shared_ptr<MemTracker>& tracker) {
> _prepared = true;
> ...
> }
>
> Status ExprContext::open(RuntimeState* state) {
> DCHECK(_prepared);
> ...
> }
> ```
>
> Maybe you can refer to the `ExprContext` method to avoid repeatedly calling prepare by mistake?
The prepare method is normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] qzsee commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
qzsee commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910058088
> This bug has been fixed in new version
Yesterday, I tested the latest master branch and did not have this problem. However, version 0.14 still has this problem. Aren't we going to fix this bug in 0.14?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg closed pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
yangzhg closed pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] qzsee closed pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
qzsee closed pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-909937505
```cpp
Status ExprContext::prepare(RuntimeState* state, const RowDescriptor& row_desc,
const std::shared_ptr<MemTracker>& tracker) {
_prepared = true;
...
}
Status ExprContext::open(RuntimeState* state) {
DCHECK(_prepared);
...
}
```
Maybe you can refer to the `ExprContext` method to avoid repeatedly calling prepare by mistake?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-909935262
This bug has been fixed in new version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] qzsee commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
qzsee commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910064230
> ```c++
> Status ExprContext::prepare(RuntimeState* state, const RowDescriptor& row_desc,
> const std::shared_ptr<MemTracker>& tracker) {
> _prepared = true;
> ...
> }
>
> Status ExprContext::open(RuntimeState* state) {
> DCHECK(_prepared);
> ...
> }
> ```
>
> Maybe you can refer to the `ExprContext` method to avoid repeatedly calling prepare by mistake?
The process of preparing is normal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on pull request #6526: [BUG]Join query result is unstable when the predicate is pushed down to exchange node
Posted by GitBox <gi...@apache.org>.
yangzhg commented on pull request #6526:
URL: https://github.com/apache/incubator-doris/pull/6526#issuecomment-910165007
> > This bug has been fixed in new version
>
> Yesterday, I tested the latest master branch and did not have this problem. However, version 0.14 still has this problem. Aren't we going to fix this bug in 0.14?
you should use https://github.com/baidu/palo/releases/tag/PALO-0.14.12.4-release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org