You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by shils <gi...@git.apache.org> on 2016/10/08 16:44:58 UTC

[GitHub] groovy pull request #442: GROOVY-7953: property expressions for extension me...

GitHub user shils opened a pull request:

    https://github.com/apache/groovy/pull/442

    GROOVY-7953: property expressions for extension methods on primitives\u2026

    \u2026 fail STC

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shils/groovy GROOVY-7953

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/442.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #442
    
----
commit 1e374d184cf19fe2aad19f8058f7bb284c07a6ca
Author: Shil Sinha <sh...@gmail.com>
Date:   2016-10-06T21:39:27Z

    GROOVY-7953: property expressions for extension methods on primitives fail STC

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request #442: GROOVY-7953: property expressions for extension me...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/442


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request #442: GROOVY-7953: property expressions for extension me...

Posted by shils <gi...@git.apache.org>.
Github user shils commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/442#discussion_r82517775
  
    --- Diff: src/spec/test-resources/META-INF/services/org.codehaus.groovy.runtime.ExtensionModule ---
    @@ -17,5 +17,5 @@
     # IT IS A WORKAROUND FOR 2 DESCRIPTORS ON CLASSPATH!
     moduleName=Test module
     moduleVersion=1.0-test
    -extensionClasses=support.MaxRetriesExtension,org.codehaus.groovy.runtime.m12n.TestStringExtension,org.codehaus.groovy.runtime.m12n.Groovy6496Extension
    +extensionClasses=support.MaxRetriesExtension,org.codehaus.groovy.runtime.m12n.TestStringExtension,org.codehaus.groovy.runtime.m12n.Groovy6496Extension,,org.codehaus.groovy.runtime.m12n.TestPrimitiveWrapperExtension
    --- End diff --
    
    good catch, fixed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request #442: GROOVY-7953: property expressions for extension me...

Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on a diff in the pull request:

    https://github.com/apache/groovy/pull/442#discussion_r82509499
  
    --- Diff: src/spec/test-resources/META-INF/services/org.codehaus.groovy.runtime.ExtensionModule ---
    @@ -17,5 +17,5 @@
     # IT IS A WORKAROUND FOR 2 DESCRIPTORS ON CLASSPATH!
     moduleName=Test module
     moduleVersion=1.0-test
    -extensionClasses=support.MaxRetriesExtension,org.codehaus.groovy.runtime.m12n.TestStringExtension,org.codehaus.groovy.runtime.m12n.Groovy6496Extension
    +extensionClasses=support.MaxRetriesExtension,org.codehaus.groovy.runtime.m12n.TestStringExtension,org.codehaus.groovy.runtime.m12n.Groovy6496Extension,,org.codehaus.groovy.runtime.m12n.TestPrimitiveWrapperExtension
    --- End diff --
    
    superfluous comma


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---