You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/02 07:16:06 UTC
[GitHub] [superset] EugeneTorap opened a new pull request, #20941: Use SPA Dataset link in Chart and Dashboard
EugeneTorap opened a new pull request, #20941:
URL: https://github.com/apache/superset/pull/20941
Improve #20890 PR logic and use dataset links in SPA in Chart and Dashboard
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
@michael-s-molina @kgabryje
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a diff in pull request #20941: Use SPA Dataset link in Chart and Dashboard
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on code in PR #20941:
URL: https://github.com/apache/superset/pull/20941#discussion_r935399224
##########
superset-frontend/src/dashboard/components/AddSliceCard/AddSliceCard.tsx:
##########
@@ -262,10 +263,16 @@ const AddSliceCard: React.FC<{
`}
>
<MetadataItem label={t('Viz type')} value={vizName} />
- <MetadataItem
- label={t('Dataset')}
- value={<a href={datasourceUrl}>{datasourceName}</a>}
- />
+ {datasourceUrl && (
Review Comment:
Can you display the `datasourceName` when `datasourceUrl` is `undefined`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20941: Use SPA Dataset link in Chart and Dashboard
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20941:
URL: https://github.com/apache/superset/pull/20941#issuecomment-1202243215
# [Codecov](https://codecov.io/gh/apache/superset/pull/20941?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20941](https://codecov.io/gh/apache/superset/pull/20941?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5cf0ee6) into [master](https://codecov.io/gh/apache/superset/commit/34ad80c6420e55ab4253eb57ddc0aa067f56a11d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34ad80c) will **increase** coverage by `0.00%`.
> The diff coverage is `50.00%`.
```diff
@@ Coverage Diff @@
## master #20941 +/- ##
=======================================
Coverage 66.35% 66.35%
=======================================
Files 1766 1766
Lines 67124 67125 +1
Branches 7129 7130 +1
=======================================
+ Hits 44541 44542 +1
Misses 20759 20759
Partials 1824 1824
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `52.12% <50.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20941?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [...dashboard/components/AddSliceCard/AddSliceCard.tsx](https://codecov.io/gh/apache/superset/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0FkZFNsaWNlQ2FyZC9BZGRTbGljZUNhcmQudHN4) | `65.90% <0.00%> (-1.54%)` | :arrow_down: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `59.13% <100.00%> (ΓΈ)` | |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/superset/pull/20941/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <0.00%> (+33.33%)` | :arrow_up: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] lyndsiWilliams commented on pull request #20941: fix: Use SPA Dataset link in Chart and Dashboard
Posted by GitBox <gi...@apache.org>.
lyndsiWilliams commented on PR #20941:
URL: https://github.com/apache/superset/pull/20941#issuecomment-1203273299
I've just merged a fix for this failing test on CI. If you pull from master your CI should pass π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #20941: fix: Use SPA Dataset link in Chart and Dashboard
Posted by GitBox <gi...@apache.org>.
kgabryje merged PR #20941:
URL: https://github.com/apache/superset/pull/20941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on pull request #20941: fix: Use SPA Dataset link in Chart and Dashboard
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on PR #20941:
URL: https://github.com/apache/superset/pull/20941#issuecomment-1203569091
> I've just merged a fix for this failing test on CI. If you pull from master your CI should pass π
Done :relaxed:
@michael-s-molina Can we merge the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] EugeneTorap commented on a diff in pull request #20941: Use SPA Dataset link in Chart and Dashboard
Posted by GitBox <gi...@apache.org>.
EugeneTorap commented on code in PR #20941:
URL: https://github.com/apache/superset/pull/20941#discussion_r935459257
##########
superset-frontend/src/dashboard/components/AddSliceCard/AddSliceCard.tsx:
##########
@@ -262,10 +263,16 @@ const AddSliceCard: React.FC<{
`}
>
<MetadataItem label={t('Viz type')} value={vizName} />
- <MetadataItem
- label={t('Dataset')}
- value={<a href={datasourceUrl}>{datasourceName}</a>}
- />
+ {datasourceUrl && (
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org