You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/22 11:33:34 UTC
[GitHub] [pulsar-helm-chart] tisonkun opened a new issue, #290: Release Pulsar Helm Chart in GitHub Pages flavor
tisonkun opened a new issue, #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290
Currently, we host Pulsar Helm Chart's metadata (`index.yaml`) on https://pulsar.apache.org/charts/index.yaml. Users encountered an issue today (https://github.com/apache/pulsar/issues/17799) due to we removed the file during "clean up" content before building the official website fully.
Depending on another repo is brittle. It's hard to ensure further development happening in the pulsar-site repo is aware of this trick while this is critical to the pulsar-helm-chart usage.
I propose we adopt releasing Pulsar Helm Chart in GitHub Pages flavor to make this chart self-contained.
* Helm official document: https://helm.sh/docs/howto/chart_releaser_action/
* Chart release action: https://github.com/helm/chart-releaser-action
* A live example from OpenSearch:
* https://github.com/opensearch-project/helm-charts/blob/main/.github/workflows/release.yaml
* https://github.com/opensearch-project/helm-charts/blob/gh-pages/index.yaml
The implementation steps are:
1. Create `gh-pages` branch on pulsar-helm-chart repo.
2. Ask Apache INFRA team to config the branch as the GitHub Pages branch.
3. Add the workflow using chart-releaser-action (bundled in this repo, it's lightweight).
4. (optionally) redirect https://pulsar.apache.org/charts to the new place.
The last step _may_ be optional because IIUC helm chart's index is global. Thus once we publish the first new index with chart-releaser-action, all downloads to the chart will find the index from the new place. Although, I'm not an expert on Helm Chart so here requires some verification. (cc @lhotari @mattisonchao @yaalsn)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] ericsyh commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor
Posted by GitBox <gi...@apache.org>.
ericsyh commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1255750210
It makes sense to maintain the chart release in its own repo.
If possible, I think ASF Infra can consider maintaining a https://github.com/helm/chartmuseum server and all charts under ASF can use this chartmuseum server to release and manage releases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1255748884
Thanks for your proposal @tisonkun. Here is a relevant mailing list discussion https://lists.apache.org/thread/2xmks3zzkh5cm4ghrqt4ys6zwh4c3gbj.
I think we should update the release process so that it properly follows Apache guidelines, requiring signed tarballs and 3 PMC votes. I also think we should host the `index.yaml` and the tarballs on `https://dist.apache.org/repos/dist/release/pulsar`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] tisonkun commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1271745474
Thanks for your feedback @michaeljmarshall @ericsyh @yaalsn. Sorry for the late reply.
Although any Apache TLP needs not to follow approaches adopted by other projects, I try to see how other projects do it:
CouchDB, APISIX, and ShenYu use the GitHub Actions + GitHub Pages way.
* https://github.com/apache/couchdb-helm/blob/main/.github/workflows/chart-releaser.yaml
* https://github.com/apache/apisix-helm-chart/blob/master/.github/workflows/release.yaml
* https://github.com/apache/shenyu-helm-chart/blob/main/.github/workflows/release.yml
SkyWalking and Tika publish the Chart to https://apache.jfrog.io. I don't find the release manual yet.
* https://github.com/apache/skywalking-kubernetes
* https://github.com/apache/tika-helm
@michaeljmarshall I ever thought of the release process based on dist.a.o. But thinking once more about the archive policy and upload process I tend to avoid them if we can.
Thus, I'd like to continue to introduce the GitHub Pages flavor release. @michaeljmarshall does it make sense to you?
Related actions have been added to whitelist: https://issues.apache.org/jira/browse/INFRA-23716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] tisonkun commented on issue #290: Release Pulsar Helm Chart on dist.apache.org
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1286484455
@michaeljmarshall I've updated the title and gonna close it once we don't have a dependency on the existence of the very file ([content/charts/index.yaml](https://github.com/apache/pulsar-site/blob/asf-site-next/content/charts/index.yaml)) - redirection is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] yaalsn commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor
Posted by GitBox <gi...@apache.org>.
yaalsn commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1255883480
IMO, serving `index.yaml` in GitHub page makes sense.
1. This file doesn't need to be visited frequently.
2. Even if GitHub turn down, Github Engs will fix it as soon as possible.
3. SN uses the GitHub page to serve the file and it works well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1278240227
I'm just seeing your response and PR now. Thanks for working on this @tisonkun.
I think we should get specific permission from the ASF to verify this release process. I am going to figure out how to get a discussion going to move this forward.
My primary concerns are that this flow releases code/binaries that not voted on by the PMC, release artifacts are not signed, and release artifacts are not verified before publication. This is my primary source https://www.apache.org/legal/release-policy.html.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #290: Release Pulsar Helm Chart on dist.apache.org
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1286498703
Thanks @tisonkun! That sounds great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] tisonkun commented on issue #290: Release Pulsar Helm Chart on dist.apache.org
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1306906910
@michaeljmarshall Thanks for your update. I noticed https://github.com/apache/pulsar-site/commit/460ae87cb24723757e768a77388c15726ed2ecf9 days ago. As long as the release process writes to update the file in the main branch instead of the deploy branch, I'm OK that it's enough to prevent accidental removal.
Closed as done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1279300054
The airflow process is defined here https://github.com/apache/airflow/blob/main/dev/README_RELEASE_HELM_CHART.md. I will take a closer look at it and see if we can learn from their process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #290: Release Pulsar Helm Chart on dist.apache.org
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1302934399
@tisonkun - I think we might need to figure out a different way to maintain the `index.yaml`. @dave2wave mentioned that artifacts at `dist.a.o` need to be signed, and given that the file would keep moving, I'm not sure how we would make it work correctly. In order to not block the 3.0.0 release, I went ahead and added the `index.yaml` to the `main` branch in `pulsar-site` so that it'll be slightly harder to accidentally delete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] tisonkun closed issue #290: Release Pulsar Helm Chart on dist.apache.org
Posted by GitBox <gi...@apache.org>.
tisonkun closed issue #290: Release Pulsar Helm Chart on dist.apache.org
URL: https://github.com/apache/pulsar-helm-chart/issues/290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] tisonkun commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1272455470
I'm going to submit a pull request to this repo. And it still needs a committer to help create the `gh-pages` branch (identical to master is OK for initialization).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] tisonkun commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor
Posted by GitBox <gi...@apache.org>.
tisonkun commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1255725476
cc @lhotari @mattisonchao @yaalsn @ericsyh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1278244340
I found this relevant jira ticket: https://issues.apache.org/jira/browse/LEGAL-573. It shows that the Apache Airflow project is using a formal voting process and is having their binaries hosted on dist.apache.org. Here is one of their release votes: https://lists.apache.org/thread/cfr5q9jccdw1l61yg1qojt1po96cb8c5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on issue #290: Release Pulsar Helm Chart in GitHub Pages flavor
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #290:
URL: https://github.com/apache/pulsar-helm-chart/issues/290#issuecomment-1283381624
> Another risk is that the reliability of pulsar.apache.org is promised by the ASF INFRA team, while GitHub Pages are handled by the GitHub team. I'd say GitHub is less stable than ASF sites.
I do agree that it is risky. My preference is to host the `index.yaml` ourselves, but we could also start a discussion on the mailing list to see if others are opinionated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org