You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/05/14 18:24:45 UTC
[GitHub] [incubator-pinot] mayankshriv commented on a change in pull request #6922: Enhance PinotSegmentRecordReader to preserve null values
mayankshriv commented on a change in pull request #6922:
URL: https://github.com/apache/incubator-pinot/pull/6922#discussion_r632712429
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/minion/SegmentPurger.java
##########
@@ -165,6 +160,7 @@ public boolean hasNext() {
// Try to get the next row to return
while (_pinotSegmentRecordReader.hasNext()) {
+ _nextRow.clear();
Review comment:
Should the clear be inside of next()? So that callers don't need to explicit call?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org