[jira] [Comment Edited] (STORM-658) config topology.acker.executors default value is null and then should not start acker bolts

["Jungtaek Lim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14598718#comment-14598718 ] 

Jungtaek Lim edited comment on STORM-658 at 6/24/15 1:48 AM:
-------------------------------------------------------------

{code}
(defn add-acker! [storm-conf ^StormTopology ret]
  (let [num-executors (if (nil? (storm-conf TOPOLOGY-ACKER-EXECUTORS)) (storm-conf TOPOLOGY-WORKERS) (storm-conf TOPOLOGY-ACKER-EXECUTORS))
{code}

Setting null to "topology.acker.executors" is intentional (It is only way to use 1 acker per worker), but it looks like easy to be confusing (This issue is started with confusion) and it seems not be documented properly any places.


was (Author: kabhwan):
{code}
(defn add-acker! [storm-conf ^StormTopology ret]
  (let [num-executors (if (nil? (storm-conf TOPOLOGY-ACKER-EXECUTORS)) (storm-conf TOPOLOGY-WORKERS) (storm-conf TOPOLOGY-ACKER-EXECUTORS))
{code}

Setting null to "topology.acker.executors" is intentional (It is only way to use 1 acker per worker), but it looks like easy to confuse (This issue is started with confusion) and it seems not be documented properly any places.

> config topology.acker.executors default value is null and then should not start acker bolts
> -------------------------------------------------------------------------------------------
>
>                 Key: STORM-658
>                 URL: https://issues.apache.org/jira/browse/STORM-658
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: caofangkun
>            Assignee: caofangkun
>            Priority: Minor
>         Attachments: executors num is wrong.png, is null.png
>
>
> See Code:
> https://github.com/caofangkun/apache-storm/blob/master/storm-core/src/clj/backtype/storm/daemon/common.clj#L315
> Config "topology.acker.executors" default value is null
> then acker executors will be same as "topology.workers"
> $ storm jar storm-starter-0.10.0-SNAPSHOT.jar storm.starter.ExclamationTopology ExclamationTopology
> Executors show up as 18 executors = 10(word) + 3(exclaim1) + 2(exclaim2) + 3(acker bolt)
> But the 3 acker bolt executors will not be used.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)