You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/13 11:18:56 UTC
[GitHub] [superset] vladimir-remar opened a new issue #16248: Dashboards does not load properly.
vladimir-remar opened a new issue #16248:
URL: https://github.com/apache/superset/issues/16248
### Expected results
A dashboard properly loaded before its sended in email
### Actual results.
It seems even with EMAIL_PAGE_RENDER_WAIT increased does not wait the time to take the screenshot
```
Aug 13 11:42:00 ip-172-31-47-99 bash[170558]: Scheduling alert email_test eta: 2021-08-13 11:42:00+02:00
Aug 13 11:42:00 ip-172-31-47-99 bash[170558]: Init selenium driver
Aug 13 11:42:07 ip-172-31-47-99 bash[170558]: Taking a PNG screenshot or url https://XXXXXX/superset/dashboard/14/
Aug 13 11:42:11 ip-172-31-47-99 bash[170558]: Report sent to email
```
#### Screenshots
What I get
What I Expect
#### How to reproduce
I create a properly enviroment for superset and run the following commands:
```
export SUPERSET_CONFIG_PATH=/home/ubuntu/Work/Superset/superset_config.py
gunicorn -w 10 -k gevent -b 0.0.0.0:8080 --limit-request-line 0 --limit-request-field_size 0 --log-file=/home/ubuntu/supersetDir/gunicorn.log "superset.app:create_app()"
celery worker --app=superset.tasks.celery_app:app --pool=prefork -O fair -c 4 --logfile=/home/ubuntu/supersetDir/celeryworker.logs --pidfile=/home/ubuntu/supersetDir/celery-worker.pid --loglevel=info
celery beat --app=superset.tasks.celery_app:app --logfile=/home/ubuntu/supersetDir/celerybeatlog.logs
```
### Environment
- superset version: 1.2
- python version: Python 3.8.10
- any feature flags active:
```
FEATURE_FLAGS = {
"ALERT_REPORTS": True,
"DASHBOARD_NATIVE_FILTERS": True,
"THUMBNAILS": True,
"OMNIBAR": True,
"LISTVIEWS_DEFAULT_CARD_VIEW": True,
"THUMBNAILS_SQLA_LISTENERS": True,
}
```
Part of my superset_config.py
```
class CeleryConfig(object):
BROKER_URL = 'redis://%s:%s/0' % (REDIS_HOST, REDIS_PORT)
CELERY_IMPORTS = ('superset.sql_lab', "superset.tasks", "superset.tasks.thumbnails", )
CELERY_RESULT_BACKEND = 'redis://%s:%s/0' % (REDIS_HOST, REDIS_PORT)
CELERYD_PREFETCH_MULTIPLIER = 10
CELERY_ACKS_LATE = True
CELERY_ANNOTATIONS = {
'sql_lab.get_sql_results': {
'rate_limit': '100/s',
},
'email_reports.send': {
'rate_limit': '1/s',
'time_limit': 600,
'soft_time_limit': 600,
'ignore_result': True,
},
}
CELERYBEAT_SCHEDULE = {
'email_reports.schedule_hourly': {
'task': 'email_reports.schedule_hourly',
'schedule': crontab(minute=1, hour='*'),
},
'alerts.schedule_check': {
'task': 'alerts.schedule_check',
'schedule': crontab(minute='*', hour='*'),
},
'reports.scheduler': {
'task': 'reports.scheduler',
'schedule': crontab(minute='*', hour='*'),
},
'reports.prune_log': {
'task': 'reports.prune_log',
'schedule': crontab(minute=0, hour=0),
},
'cache-warmup-hourly': {
'task': 'cache-warmup',
'schedule': crontab(minute='*/30', hour='*'),
'kwargs': {
'strategy_name': 'top_n_dashboards',
'top_n': 10,
'since': '7 days ago',
},
},
}
CELERY_CONFIG = CeleryConfig
#Config Email notfication
EMAIL_REPORTS_CRON_RESOLUTION = 15
EMAIL_PAGE_RENDER_WAIT = 30
EMAIL_NOTIFICATIONS = True
EMAIL_PAGE_RENDER_WAIT = 30
```
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #16248: Dashboards does not load properly.
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #16248:
URL: https://github.com/apache/superset/issues/16248#issuecomment-898387337
Hmm, it appears we should introduce a chart prop to skip animations that is set to `true` when thumbs/reports are rendered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #16248: Dashboards does not load properly.
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #16248:
URL: https://github.com/apache/superset/issues/16248#issuecomment-898396554
My guess is this would require the following:
- a PR on https://github.com/apache-superset/superset-ui that adds a `disableAnimations` prop to the `ChartProps` class.
- Add support for a `disableAnimations` URL parameter that then gets passed to the chart component.
It shouldn't be that hard to do if you know TypeScript and React. Let me know if you want to take this on!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nytai commented on issue #16248: Dashboards does not load properly.
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #16248:
URL: https://github.com/apache/superset/issues/16248#issuecomment-898574067
You can also configure
https://github.com/apache/superset/blob/6cd15d54a0ca503b6d050e296d66876383c31365/superset/config.py#L507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] vladimir-remar commented on issue #16248: Dashboards does not load properly.
Posted by GitBox <gi...@apache.org>.
vladimir-remar commented on issue #16248:
URL: https://github.com/apache/superset/issues/16248#issuecomment-898391865
@villebro Thanks for answer, Now I get it, any advice on this? or just wait to the implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #16248: Dashboards does not load properly.
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #16248:
URL: https://github.com/apache/superset/issues/16248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #16248: Dashboards does not load properly.
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #16248:
URL: https://github.com/apache/superset/issues/16248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org