You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/05/17 11:28:56 UTC
Review Request: Fix for CLOUDSTACK-2354 Unable to create Windows VMs using
ISO
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11216/
-----------------------------------------------------------
Review request for cloudstack and Nitin Mehta.
Description
-------
CLOUDSTACK-2354 Unable to create Windows VMs using ISO
Fix is to maintain the memory constraints provided by the xenserver.
Dynamic Minimum ? 1?4 Static Maximum
0 ? memory-static-min ? memory-dynamic-min ? memory-dynamic-max ? memory-static-max
Adding fix in support to memory and cpu overcommit ratios
This addresses bug CLOUDSTACK-2354.
Diffs
-----
core/src/com/cloud/agent/api/ScaleVmCommand.java 35d22ad
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java be47754
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java 3ca0b60
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java a166347
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 24cb75c
plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java 877e3bc
server/src/com/cloud/hypervisor/HypervisorGuruBase.java ca1644a
server/src/com/cloud/vm/VirtualMachineManagerImpl.java d153bb2
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java dd51e74
Diff: https://reviews.apache.org/r/11216/diff/
Testing
-------
Tested locally for guest vms and system vms
Thanks,
Harikrishna Patnala
Re: Review Request: Fix for CLOUDSTACK-2354 Unable to create Windows VMs
using ISO
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11216/
-----------------------------------------------------------
(Updated May 17, 2013, 9:29 a.m.)
Review request for cloudstack and Nitin Mehta.
Description (updated)
-------
CLOUDSTACK-2354 Unable to create Windows VMs using ISO
Fix is to maintain the memory constraints provided by the xenserver.
Dynamic Minimum >= 1/4 * Static Maximum
0 <= memory-static-min <= memory-dynamic-min <= memory-dynamic-max <= memory-static-max
Adding fix in support to memory and cpu overcommit ratios
This addresses bug CLOUDSTACK-2354.
Diffs
-----
core/src/com/cloud/agent/api/ScaleVmCommand.java 35d22ad
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java be47754
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java 3ca0b60
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java a166347
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 24cb75c
plugins/hypervisors/xen/test/com/cloud/hypervisor/xen/resource/CitrixResourceBaseTest.java 877e3bc
server/src/com/cloud/hypervisor/HypervisorGuruBase.java ca1644a
server/src/com/cloud/vm/VirtualMachineManagerImpl.java d153bb2
server/test/com/cloud/vm/VirtualMachineManagerImplTest.java dd51e74
Diff: https://reviews.apache.org/r/11216/diff/
Testing
-------
Tested locally for guest vms and system vms
Thanks,
Harikrishna Patnala