You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/09/17 09:33:13 UTC

[GitHub] [carbondata] ShreelekhyaG commented on a change in pull request #4218: [CARBONDATA-4285] Fix alter add complex columns with global sort compaction failure

ShreelekhyaG commented on a change in pull request #4218:
URL: https://github.com/apache/carbondata/pull/4218#discussion_r710905325



##########
File path: processing/src/main/java/org/apache/carbondata/processing/loading/BadRecordsLoggerProvider.java
##########
@@ -33,6 +33,16 @@
    * @return
    */
   public static BadRecordsLogger createBadRecordLogger(CarbonDataLoadConfiguration configuration) {
+    return createBadRecordLogger(configuration, false);
+  }
+  /**
+   * method returns the BadRecordsLogger instance
+   * @param configuration
+   * @return
+   */
+

Review comment:
       remove extra line at 43 and add one at 38




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org