You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/12 15:36:16 UTC
[GitHub] [commons-compress] arturobernalg opened a new pull request #157: [COMPRESS-561] - Minor improvement
arturobernalg opened a new pull request #157:
URL: https://github.com/apache/commons-compress/pull/157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] coveralls edited a comment on pull request #157: [COMPRESS-561] - Minor improvement
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #157:
URL: https://github.com/apache/commons-compress/pull/157#issuecomment-743774094
[](https://coveralls.io/builds/35663738)
Coverage increased (+0.001%) to 87.274% when pulling **dbfd1d57f827f234b6954ad96e4e1f630cc264c6 on arturobernalg:feature/COMPRESS-561** into **4cf5b340bfb881457fc03819f1b2a651c798c5af on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] coveralls commented on pull request #157: [COMPRESS-561] - Minor improvement
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #157:
URL: https://github.com/apache/commons-compress/pull/157#issuecomment-743774094
[](https://coveralls.io/builds/35663595)
Coverage increased (+0.001%) to 87.274% when pulling **661b62dbc7026584df8c24c2f0a13166af9a256e on arturobernalg:feature/COMPRESS-561** into **4cf5b340bfb881457fc03819f1b2a651c798c5af on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee commented on a change in pull request #157: [COMPRESS-561] - Minor improvement
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee commented on a change in pull request #157:
URL: https://github.com/apache/commons-compress/pull/157#discussion_r542161610
##########
File path: src/main/java/org/apache/commons/compress/archivers/ar/ArArchiveOutputStream.java
##########
@@ -137,14 +137,15 @@ private long writeEntryHeader(final ArArchiveEntry pEntry) throws IOException {
boolean mustAppendName = false;
final String n = pEntry.getName();
- if (LONGFILE_ERROR == longFileMode && n.length() > 16) {
+ final int nLength = n.length();
Review comment:
I can't see much benefit from extracting `n.length()` to a final `nlength`. Maybe it's performance benefiting or something else?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-compress] PeterAlfredLee merged pull request #157: [COMPRESS-561] - Minor improvement
Posted by GitBox <gi...@apache.org>.
PeterAlfredLee merged pull request #157:
URL: https://github.com/apache/commons-compress/pull/157
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org