You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by GitBox <gi...@apache.org> on 2020/01/30 21:06:21 UTC
[GitHub] [tomee] bitcod3r opened a new pull request #628: TOMEE-2767 /
Deleting typos and correcting heading syntax
bitcod3r opened a new pull request #628: TOMEE-2767 / Deleting typos and correcting heading syntax
URL: https://github.com/apache/tomee/pull/628
I confirm that:
- Code compiles with JDK 8
- And, all tests pass successfully.
This is my first PR to the TomEE project. Please, give me your feedback to know what might I improve.
More PRs are coming... :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] bitcod3r commented on issue #628: TOMEE-2767 / Deleting
typos and correcting heading syntax
Posted by GitBox <gi...@apache.org>.
bitcod3r commented on issue #628: TOMEE-2767 / Deleting typos and correcting heading syntax
URL: https://github.com/apache/tomee/pull/628#issuecomment-580512058
> Personally, I think the page would look even better with the links in unordered lists rather than paragraphs with line breaks. Does anyone agree?
+1 @djencks, I agree with you. It is semantically correct to markup those links as (unordered) lists of resources. Adding 1 commit to the current PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] cesarhernandezgt merged pull request #628: TOMEE-2767 /
Deleting typos and correcting heading syntax
Posted by GitBox <gi...@apache.org>.
cesarhernandezgt merged pull request #628: TOMEE-2767 / Deleting typos and correcting heading syntax
URL: https://github.com/apache/tomee/pull/628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [tomee] djencks commented on issue #628: TOMEE-2767 / Deleting
typos and correcting heading syntax
Posted by GitBox <gi...@apache.org>.
djencks commented on issue #628: TOMEE-2767 / Deleting typos and correcting heading syntax
URL: https://github.com/apache/tomee/pull/628#issuecomment-580494079
I think this is a fantastic change, thanks!
Personally, I think the page would look even better with the links in unordered lists rather than paragraphs with line breaks. Does anyone agree?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services