You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "crepererum (via GitHub)" <gi...@apache.org> on 2023/02/15 12:52:04 UTC
[GitHub] [arrow-rs] crepererum opened a new pull request, #3723: feat: impl `Ord`/`PartialOrd` for `SortOptions`
crepererum opened a new pull request, #3723:
URL: https://github.com/apache/arrow-rs/pull/3723
# Which issue does this PR close?
\-
# Rationale for this change
Makes it easier to use `SortOptions` in other code bases (esp. you can auto-derive `Ord` for other types that use `SortOptions`).
# What changes are included in this PR?
Auto-derive `Ord`/`PartialOrd` for `SortOptions`.
# Are there any user-facing changes?
\-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3723: feat: impl `Ord`/`PartialOrd` for `SortOptions`
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #3723:
URL: https://github.com/apache/arrow-rs/pull/3723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3723: feat: impl `Ord`/`PartialOrd` for `SortOptions`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #3723:
URL: https://github.com/apache/arrow-rs/pull/3723#issuecomment-1433069593
Benchmark runs are scheduled for baseline = 22c138156715bf62c8c683fb94e947f7a3200149 and contender = 55c598d09d6268f97181e17c080d5f6a99545a4e. 55c598d09d6268f97181e17c080d5f6a99545a4e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/70e83d60290f4d878d28ea2c5f830fcf...87fe614af0574da7b966ee265ca4ca12/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d41605941bd34acd836dc596fadc209e...1d4da7c55afc46c19c3c9318a6c839cf/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/deccfbd8ad964e32b6d9ae08a48a01c2...91e80441492d4d3aa46222ebf29a98b2/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/e41c7beb39654b1da970c5315a3e5d50...26cf254e225b454a99e11ccc12a18a1b/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] crepererum commented on pull request #3723: feat: impl `Ord`/`PartialOrd` for `SortOptions`
Posted by "crepererum (via GitHub)" <gi...@apache.org>.
crepererum commented on PR #3723:
URL: https://github.com/apache/arrow-rs/pull/3723#issuecomment-1431434303
The use case is that it has SOME deterministic ordering so I can order groups of sorted files downstream in IOx to generate a deterministic output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3723: feat: impl `Ord`/`PartialOrd` for `SortOptions`
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #3723:
URL: https://github.com/apache/arrow-rs/pull/3723#issuecomment-1431352366
What is the significance of the output sort order? I guess I'm asking what the intended use-case is?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org