You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2006/11/03 19:15:15 UTC
[Bug 5165] New: RFE: sa-update --checkonly
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
Summary: RFE: sa-update --checkonly
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P5
Component: sa-update
AssignedTo: dev@spamassassin.apache.org
ReportedBy: anomie@users.sourceforge.net
I'd prefer to have a cronjob only check for available updates and email me if
any are available, rather than have them installed unattended. If sa-update
had a --checkonly option, I could do this easily.
I will attach a patch momentarily.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #3742 is|0 |1
obsolete| |
------- Additional Comments From spamassassin@dostech.ca 2006-11-15 10:44 -------
Created an attachment (id=3752)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3752&action=view)
minor tweak: check all channels for updates
Checks all the channels for updates instead of exiting after the first channel
with an available update.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
------- Additional Comments From spamassassin@dostech.ca 2006-12-08 13:50 -------
[dos@FC5-VPC 3.1]$ svn ci -m "bug 5165: implement sa-update --checkonly"
Sending sa-update.raw
Transmitting file data .
Committed revision 484806.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
------- Additional Comments From spamassassin@dostech.ca 2006-11-15 15:23 -------
(In reply to comment #9)
> Fair enough, but this patch doesn't mail anyone. Does it even output the
> channels that need updating in something other than a debug statement? I guess
> you could grep out the channels from debug, then based on the exit value send a
> mail about it.
Yeah, sending the mail is still the problem of the caller. -Dchannel results in
five lines of output per channel, which is a little verbose.
> I had assumed the idea was something like "sa-update --checkonly
> && mail -s 'Updates are necessary' root@example.com < /dev/null" as opposed to
> getting details.
Which still works... but we might as well provide a way to get the info if
somebody wants it. I think it's useful to have -- I can't stand status messages
that result in me having to go (and often literally go find a computer somewhere
to) run some command to get a little more detail to determine if I need/want to
take action.
> It feels like this ought to be combined with bug 5043, btw.
While this'd be something that could be mailed by whatever gets done in bug
5043, it's certainly not dependent on that bug.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
------- Additional Comments From felicity@apache.org 2006-11-15 14:52 -------
(In reply to comment #8)
> The way I see it, is that if you're going to have an email prompt you to do the
> update manually, you might as well know what channel(s) have updates available.
Fair enough, but this patch doesn't mail anyone. Does it even output the
channels that need updating in something other than a debug statement? I guess
you could grep out the channels from debug, then based on the exit value send a
mail about it. I had assumed the idea was something like "sa-update --checkonly
&& mail -s 'Updates are necessary' root@example.com < /dev/null" as opposed to
getting details.
It feels like this ought to be combined with bug 5043, btw.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |needs 2 votes
------- Additional Comments From spamassassin@dostech.ca 2006-11-15 10:45 -------
[dos@FC5-VPC trunk]$ svn ci -m "bug 5165: check all sa-update channels for
updates in --checkonly mode"
Sending sa-update.raw
Transmitting file data .
Committed revision 475353.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
------- Additional Comments From jm@jmason.org 2006-11-15 11:26 -------
does it make a whole lot of difference? afaics, the only diff would be
additional debug messages saying dbg("channel: $channel: update available, not
downloading in checkonly mode"), one for each channel. The exit status would be
0 with either patch.
+1 anyway ;)
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
------- Additional Comments From anomie@users.sourceforge.net 2006-11-03 10:16 -------
Created an attachment (id=3742)
--> (http://issues.apache.org/SpamAssassin/attachment.cgi?id=3742&action=view)
Patch to add a --checkonly option
It should apply against trunk r468374 cleanly, and against branches/3.1 r468376
with offset warnings.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
------- Additional Comments From spamassassin@dostech.ca 2006-11-15 13:53 -------
The way I see it, is that if you're going to have an email prompt you to do the
update manually, you might as well know what channel(s) have updates available.
Taking the SARE channels for instance, there's a lot of them that I'd be in no
real hurry to update, while I'd probably want to update the
updates.spamassassin.org channel a lot sooner. If I were being lazy and taking
my time to update some channels, I'd also want to know if there was actually a
lot of channels with updates availble... prompting me to actually do the updates.
I don't see the benefit in exiting early to save a few DNS queries over the
flexibility gained by checking all the channels.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
felicity@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 1 vote |go ahead
------- Additional Comments From felicity@apache.org 2006-12-08 11:44 -------
sure. +1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
------- Additional Comments From felicity@apache.org 2006-11-03 12:02 -------
sure. +1
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard| |needs 1 vote
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
jm@jmason.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|RFE: sa-update --checkonly |[review] RFE: sa-update --
| |checkonly
Target Milestone|Undefined |3.1.8
------- Additional Comments From jm@jmason.org 2006-11-03 10:32 -------
cool! applied.
Sending sa-update.raw
Transmitting file data .
Committed revision 470935.
+1 for 3.1.x.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
------- Additional Comments From felicity@apache.org 2006-11-15 12:50 -------
Yeah, I'm not sure what the point of checking all the channels would be. If
you're going to exit w/ 0 if the first channel is available, you'll exit with 0
no matter what the other channels are doing.
I'd rather have the early exit.
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
[Bug 5165] [review] RFE: sa-update --checkonly
Posted by bu...@bugzilla.spamassassin.org.
http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5165
spamassassin@dostech.ca changed:
What |Removed |Added
----------------------------------------------------------------------------
Status Whiteboard|needs 2 votes |needs 1 vote
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.