You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/02/13 08:38:42 UTC

Review Request 30974: Updated test expectations for the statusUpdate API change.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30974/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-2347
    https://issues.apache.org/jira/browse/MESOS-2347


Repository: mesos


Description
-------

Updated test expectations for the statusUpdate API change.


Diffs
-----

  src/tests/disk_quota_tests.cpp 1d3aa0c395ddcd59a5072a5a47b3cf8ed05567ed 
  src/tests/docker_containerizer_tests.cpp 8b212d4e6ed5a179ebadce1bdbbf3edde87d706c 
  src/tests/exception_tests.cpp 7a41770c26519541fed10672e13ee833a2d6dd5e 
  src/tests/external_containerizer_test.cpp d6c4437d8a9b4b46740c3a3a626908cd69081541 
  src/tests/fault_tolerance_tests.cpp efa5c57d98308e9d54723d361533b39b99551261 
  src/tests/gc_tests.cpp 45efce347af7ad6bedd193715611dc0a67f5d767 
  src/tests/health_check_tests.cpp 7fcb2310e9e9d203b78925315ff71d3f7396f099 
  src/tests/master_allocator_tests.cpp df9ac24280514932dc118408b11adc806f548f5e 
  src/tests/master_authorization_tests.cpp fadbd38f50c9587a9b1755d96a96e10c540264c5 
  src/tests/master_slave_reconciliation_tests.cpp 5156898a4ec02a2ad0080ab768e360077f0ba0f1 
  src/tests/master_tests.cpp e69a7fb39e93a9a999e0991985f5d060b72aac65 
  src/tests/mesos.hpp 60c70043c8266a422ffa03ab5a949da0bc822124 
  src/tests/partition_tests.cpp eb16a58c23e0c152212140841ed09cd7f6f139d6 
  src/tests/port_mapping_tests.cpp 308f629bc02d7bb4bbae385a0c816b567594f679 
  src/tests/reconciliation_tests.cpp 4c97341a1e84b1504090e8b3fdd8b309abf65877 
  src/tests/registrar_zookeeper_tests.cpp 30d3cd8b1e7d56fbb326c9feccd4c3cbae2015de 
  src/tests/resource_offers_tests.cpp 1ba73ba7f9c2cd042119a2bd47c16f152ebc65fa 
  src/tests/scheduler_tests.cpp 080ec7236246794de6c8cc7356a06331c5e48cd5 
  src/tests/slave_recovery_tests.cpp 8210c52afd03e2a722657c45ef8ed2dae7988022 
  src/tests/slave_tests.cpp a02e335576bf68b449a6286fa5cf5093b1b7182a 
  src/tests/status_update_manager_tests.cpp 2158cfea98d238d462abeebd3d5fe2dec4f96470 

Diff: https://reviews.apache.org/r/30974/diff/


Testing
-------

make check


Thanks,

Ben Mahler


Re: Review Request 30974: Updated MockScheduler to pass implicit acknowledgements parameter.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30974/#review73207
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On Feb. 17, 2015, 6 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30974/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2015, 6 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2347
>     https://issues.apache.org/jira/browse/MESOS-2347
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated test expectations for the statusUpdate API change.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 60c70043c8266a422ffa03ab5a949da0bc822124 
>   src/tests/slave_recovery_tests.cpp 8210c52afd03e2a722657c45ef8ed2dae7988022 
> 
> Diff: https://reviews.apache.org/r/30974/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>


Re: Review Request 30974: Updated MockScheduler to pass implicit acknowledgements parameter.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30974/
-----------------------------------------------------------

(Updated Feb. 17, 2015, 6 a.m.)


Review request for mesos and Vinod Kone.


Changes
-------

* Updates per the removal of the signature change on the API.


Summary (updated)
-----------------

Updated MockScheduler to pass implicit acknowledgements parameter.


Bugs: MESOS-2347
    https://issues.apache.org/jira/browse/MESOS-2347


Repository: mesos


Description
-------

Updated test expectations for the statusUpdate API change.


Diffs (updated)
-----

  src/tests/mesos.hpp 60c70043c8266a422ffa03ab5a949da0bc822124 
  src/tests/slave_recovery_tests.cpp 8210c52afd03e2a722657c45ef8ed2dae7988022 

Diff: https://reviews.apache.org/r/30974/diff/


Testing
-------

make check


Thanks,

Ben Mahler