[GitHub] [hbase-native-client] phrocker commented on pull request #6: HBASE-23105: Download lib double conversion, fizz, update folly

[GitBox <gi...@apache.org>]

phrocker commented on pull request #6:
URL: https://github.com/apache/hbase-native-client/pull/6#issuecomment-654886206


   > Had a chance to apply your patch locally and try it out, running into this weird linker issue.
   > 
   > > dependencies/facebook-folly-proj-install/lib/libfolly.a(AtFork.cpp.o): In function `folly::detail::(anonymous namespace)::AtForkList::AtForkList()': /hbase-native-client2/build/dependencies/facebook-folly-proj-src/folly/detail/AtFork.cpp:95: undefined reference to `pthread_atfork'
   > > collect2: error: ld returned 1 exit status
   > > CMakeFiles/simple-client.dir/build.make:139: recipe for target 'bin/examples/simple-client' failed
   > > make[2]: *** [bin/examples/simple-client] Error 1
   > > CMakeFiles/Makefile2:554: recipe for target 'CMakeFiles/simple-client.dir/all' failed
   > > make[1]: *** [CMakeFiles/simple-client.dir/all] Error 2
   > > make[1]: *** Waiting for unfinished jobs....
   > > [ 96%] Building CXX object CMakeFiles/delete-test.dir/src/test/d
   > 
   > You don't run into this? I don't see anything the patch touches related to this.. I thought find_package(Threads) should transparently handle this and set CMAKE_THREAD_LIBS_INIT and I see it is being added to simple-client.. or may be I messed something up locally.
   
   I'm back from vacation so I'll take a look with a fresh build environment. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org