You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/29 15:44:06 UTC
[GitHub] [arrow-ballista] andygrove opened a new pull request, #47: WIP: Delegate to `datafusion-proto` for logical plan serde
andygrove opened a new pull request, #47:
URL: https://github.com/apache/arrow-ballista/pull/47
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of https://github.com/apache/arrow-ballista/issues/2
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #47: Delegate to `datafusion-proto` for logical plan serde
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #47:
URL: https://github.com/apache/arrow-ballista/pull/47#issuecomment-1142293081
Moving this back to draft for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] thinkharderdev commented on pull request #47: Delegate to `datafusion-proto` for logical plan serde
Posted by GitBox <gi...@apache.org>.
thinkharderdev commented on PR #47:
URL: https://github.com/apache/arrow-ballista/pull/47#issuecomment-1142179270
@andygrove Why remove the `AsLogicalPlan` type param from the codec? In our project we use a custom logical plan representation (based on a different query AST) and it is very helpful to be able to plugin our own `LogicalPlan` type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] alamb commented on pull request #47: Delegate to `datafusion-proto` for logical plan serde
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #47:
URL: https://github.com/apache/arrow-ballista/pull/47#issuecomment-1144071923
Sorry I am catching up with PRs -- sounds like there is a good plan forward here. Thanks @andygrove and @thinkharderdev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #47: WIP: Delegate to `datafusion-proto` for logical plan serde
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #47:
URL: https://github.com/apache/arrow-ballista/pull/47#issuecomment-1140487242
@thinkharderdev @yahoNanJing fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #47: Delegate to `datafusion-proto` for logical plan serde
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #47:
URL: https://github.com/apache/arrow-ballista/pull/47#issuecomment-1146465963
Closed in favor of https://github.com/apache/arrow-ballista/pull/57
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove closed pull request #47: Delegate to `datafusion-proto` for logical plan serde
Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #47: Delegate to `datafusion-proto` for logical plan serde
URL: https://github.com/apache/arrow-ballista/pull/47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #47: Delegate to `datafusion-proto` for logical plan serde
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #47:
URL: https://github.com/apache/arrow-ballista/pull/47#issuecomment-1142299098
Having re-read the comments, I can see that this approach is not compatible with having a custom logical plan representation and this is not a feature I had considered. Also, I don't think we have any tests for this feature?
@thinkharderdev Perhaps you could add a test for your use case? I will rethink the approach here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #47: Delegate to `datafusion-proto` for logical plan serde
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #47:
URL: https://github.com/apache/arrow-ballista/pull/47#issuecomment-1142286548
> @andygrove Why remove the `AsLogicalPlan` type param from the codec? In our project we use a custom logical plan representation (based on a different query AST) and it is very helpful to be able to plugin our own `LogicalPlan` type.
@thinkharderdev the main goal was to delegate to `datafusion-proto` for logical plan serde so that we don't have to duplicate all of this code in Ballista. A secondary goal was to use the `datafusion-proto` API for converting plans to bytes and bytes to plans without having dependencies on internals of that crate (so that we can easily change the format in the future). If we create a trait for this API does that make it easy for you to plug in your own implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] andygrove commented on pull request #47: Delegate to `datafusion-proto` for logical plan serde
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #47:
URL: https://github.com/apache/arrow-ballista/pull/47#issuecomment-1142288235
Would be good to get input from @alamb as well since he is a consumer of the `datafusion-proto` API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-ballista] thinkharderdev commented on pull request #47: Delegate to `datafusion-proto` for logical plan serde
Posted by GitBox <gi...@apache.org>.
thinkharderdev commented on PR #47:
URL: https://github.com/apache/arrow-ballista/pull/47#issuecomment-1142319461
> > @andygrove Why remove the `AsLogicalPlan` type param from the codec? In our project we use a custom logical plan representation (based on a different query AST) and it is very helpful to be able to plugin our own `LogicalPlan` type.
>
> @thinkharderdev the main goal was to delegate to `datafusion-proto` for logical plan serde so that we don't have to duplicate all of this code in Ballista. A secondary goal was to use the `datafusion-proto` API for converting plans to bytes and bytes to plans without having dependencies on internals of that crate (so that we can easily change the format in the future). If we create a trait for this API does that make it easy for you to plug in your own implementation?
Yeah, my understanding is that `AsLogicalPlan` is that trait. So `datafusion-proto` can provide a set of protobuf definitions for serializing a `LogicalPlan` in a "canonical" way and implement the `AsLogicalPlan` trait for those definitions. I think it makes sense to continue using that implementation in Ballista as the default representation and rely on the implementation in `datafusion-proto`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org