[jira] [Commented] (MYNEWT-792) os_cputime functions do not return errors from hal_timer in certain cases.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MYNEWT-792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077202#comment-16077202 ] 

ASF subversion and git services commented on MYNEWT-792:
--------------------------------------------------------

Commit a731eb413725ba57976983fd6399e3262f5e8524 in mynewt-core's branch refs/heads/master from [~wes3]
[ https://gitbox.apache.org/repos/asf?p=mynewt-core.git;h=a731eb4 ]

Merge pull request #369 from wes3/myn792

MYNEWT-792: Return hal_timer error codes from os_cputime functions

> os_cputime functions do not return errors from hal_timer in certain cases.
> --------------------------------------------------------------------------
>
>                 Key: MYNEWT-792
>                 URL: https://issues.apache.org/jira/browse/MYNEWT-792
>             Project: Mynewt
>          Issue Type: Bug
>      Security Level: Public(Viewable by anyone) 
>          Components: OS
>    Affects Versions: v1_0_0_rel
>            Reporter: William San Filippo
>            Assignee: William San Filippo
>             Fix For: v1_1_0_rel
>
>
> The code in os_cputime.c, specifically os_cputime_timer_relative() and os_cputime_timer_start() do not return an error. The underlying hal_timer functions return an error in certain cases (no callback specified, timer currently running, NULL timer) but this error is not reported. This should be fixed.
> Furthermore, there should be comments in the code saying that you cannot call os_cputime_timer_relative() or os_cputime_timer_start() if the timer is currently running or an error will be returned.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)