You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Ben Reser <be...@reser.org> on 2015/05/31 23:28:39 UTC
1.9.0-rc2 up for testing/signing
The 1.9.0-rc2 release artifacts are now available for testing/signing.
Please get the tarballs from
https://dist.apache.org/repos/dist/dev/subversion
and add your signatures there.
Thanks!
RE: 1.9.0-rc2 up for testing/signing
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Bert Huijben [mailto:bert@qqmail.nl]
> Sent: dinsdag 2 juni 2015 13:54
> To: 'Ben Reser'; 'Subversion Development'
> Subject: RE: 1.9.0-rc2 up for testing/signing
>
>
>
> > -----Original Message-----
> > From: Ben Reser [mailto:ben@reser.org]
> > Sent: zondag 31 mei 2015 23:29
> > To: Subversion Development
> > Subject: 1.9.0-rc2 up for testing/signing
> >
> > The 1.9.0-rc2 release artifacts are now available for testing/signing.
> > Please get the tarballs from
> > https://dist.apache.org/repos/dist/dev/subversion
> > and add your signatures there.
>
> Can somebody help me investigate the following test failure:
Forget this...
This problem was caused by leaving a local partial patch in my test working copy, that should have fixed a BDB testrunner issue..
Reverting the patch fixed the problem.
Bert
RE: 1.9.0-rc2 up for testing/signing
Posted by Bert Huijben <be...@qqmail.nl>.
> -----Original Message-----
> From: Ben Reser [mailto:ben@reser.org]
> Sent: zondag 31 mei 2015 23:29
> To: Subversion Development
> Subject: 1.9.0-rc2 up for testing/signing
>
> The 1.9.0-rc2 release artifacts are now available for testing/signing.
> Please get the tarballs from
> https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.
Can somebody help me investigate the following test failure:
[[
W: Unexpected output
W: EXPECTED STDOUT (unordered):
W: | file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44/branches/B1 - /branches/B2:11-12
W: | /trunk:6,9
W: | file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44/branches/B2 - /trunk:9
W: | file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44/branches/B1/B/E - /branches/B2/B/E:11-12
W: | /trunk/B/E:5-6,8-9
W: ACTUAL STDOUT:
W: | file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44-1/branches/B1 - /branches/B2:11-12
W: | /trunk:6,9
W: | file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44-1/branches/B1/B/E - /branches/B2/B/E:11-12
W: | /trunk/B/E:5-6,8-9
W: | file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44-1/branches/B2 - /trunk:9
W: DIFF STDOUT (unordered):
W: | --- EXPECTED STDOUT (unordered)
W: | +++ ACTUAL STDOUT
W: | @@ -1,5 +1,5 @@
W: | -file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44/branches/B1 - /branches/B2:11-12
W: | +file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44-1/branches/B1 - /branches/B2:11-12
W: | /trunk:6,9
W: | -file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44/branches/B2 - /trunk:9
W: | -file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44/branches/B1/B/E - /branches/B2/B/E:11-12
W: | +file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44-1/branches/B1/B/E - /branches/B2/B/E:11-12
W: | /trunk/B/E:5-6,8-9
W: | +file:///R:/subversion/tests/cmdline/svn-test-work/repositories/svnrdump_tests-44-1/branches/B2 - /trunk:9
W: CWD: R:\subversion\tests\cmdline
W: EXCEPTION: SVNLineUnequal
Traceback (most recent call last):
File "F:\svn-test\dev\subversion\tests\cmdline\svntest\main.py", line 1744, in run
rc = self.pred.run(sandbox)
File "F:\svn-test\dev\subversion\tests\cmdline\svntest\testcase.py", line 178, in run
result = self.func(sandbox)
File "F:\svn-test\dev\subversion\tests\cmdline\svnrdump_tests.py", line 603, in dont_drop_valid_mergeinfo_during_incremental_svnrdump_loads
sbox.repo_url)
File "F:\svn-test\dev\subversion\tests\cmdline\svntest\actions.py", line 291, in run_and_verify_svn
expected_exit, *varargs)
File "F:\svn-test\dev\subversion\tests\cmdline\svntest\actions.py", line 331, in run_and_verify_svn2
expected_stdout, expected_stderr)
File "F:\svn-test\dev\subversion\tests\cmdline\svntest\verify.py", line 452, in verify_outputs
compare_and_display_lines(message, label, expected, actual, raisable)
File "F:\svn-test\dev\subversion\tests\cmdline\svntest\verify.py", line 425, in compare_and_display_lines
raise raisable
SVNLineUnequal
FAIL: svnrdump_tests.py 44: don't drop mergeinfo revs in incremental svnrdump
]]
At first sight it looked like a simple ordering issue, but the directory suffix changes... Perhaps this is expected, or there might be something with the matching code.
Bert
Re: 1.9.0-rc2 up for testing/signing
Posted by Branko Čibej <br...@wandisco.com>.
On 31.05.2015 23:28, Ben Reser wrote:
> The 1.9.0-rc2 release artifacts are now available for testing/signing.
> Please get the tarballs from
> https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.
We're one Windows vote short ... Windows devs, please test and vote.
-- Brane
Re: 1.9.0-rc2 up for testing/signing
Posted by Branko Čibej <br...@wandisco.com>.
Summary:
+1 to release (Windows)
Platform
Windows 10 Pro Technical Preview x64
Build tools:
Microsoft Visual Studio Proffecional 2015 RC (14.0.22823.1 D14REL)
CMake 3.2.3
SCons 2.3.4 (patched for MSVC14)
Source dependencies:
APR 1.5.2
APR-Util 1.5.4
zlib 1.2.8
httpd 2.4.12 with pcre-8.37
SQLite 3.8.8.3 (amalgamated)
Serf 1.3.8
OpenSSL 1.0.2
Other dependencies:
Python 2.7.9
Perl 5.20.2 (Strawberry Perl)
ruby 2.2.1p85 (2015-02-26 revision 49769) [x64-mingw32]
Swig 2.0.12
Java 1.8.0_45-b14
JUnit 4.11
Verified:
Tarball contents and signatures
(fsfs) x (local, svnserve, dav)
check-swig-py
check-swig-pl
Issues:
- gen-make.py doesn't recognize the Ruby install
- JavaHL does not build because our sources are not compatible
with C++11 user-defined literals that MSVC14 supports.
GPG signatures committed to the dist/dev/subversion repository.
RE: 1.9.0-rc2 up for testing/signing
Posted by Bert Huijben <be...@qqmail.nl>.
I finished the complete 2x3 testrun + additional tests earlier today. I'll add my +1 when I get home.
Bert
-----Original Message-----
From: "Branko Čibej" <br...@wandisco.com>
Sent: 2-6-2015 19:54
To: "dev@subversion.apache.org" <de...@subversion.apache.org>
Subject: Re: 1.9.0-rc2 up for testing/signing
Summary:
+1 to release (Unix)
Platform
Mac OS X 10.10.3 Yosemite, build 14D136
Standard dependencies:
Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
APR 1.4.8
APR-Util 1.5.2
zlib 1.2.5
httpd 2.4.9
Python 2.7.6
Perl 5.18.2
2.0.0p481 (2014-05-08 revision 45883)
SQLite 3.8.5
Dependencies from homebrew:
SQLite 3.8.10.2
Serf 1.3.8
OpenSSL 1.0.2a
BDB 6.1.19
libmagic 5.22
Other dependencies:
Swig 2.0.12
Java 1.8.0_45-b14
JUnit 4.11
Verified:
Tarball contents and signatures
(fsfs, bdb) x (local, svnserve, dav) with SQLite 3.8.10.2
(fsfs) x (local) with SQLite 3.8.5
check-all-javahl
check-swig-py
check-swig-rb
check-swig-pl
New issues: None
Known issues: None
GPG signatures committed to the dist/dev/subversion repository.
Re: 1.9.0-rc2 up for testing/signing
Posted by Branko Čibej <br...@wandisco.com>.
Summary:
+1 to release (Unix)
Platform
Mac OS X 10.10.3 Yosemite, build 14D136
Standard dependencies:
Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn)
APR 1.4.8
APR-Util 1.5.2
zlib 1.2.5
httpd 2.4.9
Python 2.7.6
Perl 5.18.2
2.0.0p481 (2014-05-08 revision 45883)
SQLite 3.8.5
Dependencies from homebrew:
SQLite 3.8.10.2
Serf 1.3.8
OpenSSL 1.0.2a
BDB 6.1.19
libmagic 5.22
Other dependencies:
Swig 2.0.12
Java 1.8.0_45-b14
JUnit 4.11
Verified:
Tarball contents and signatures
(fsfs, bdb) x (local, svnserve, dav) with SQLite 3.8.10.2
(fsfs) x (local) with SQLite 3.8.5
check-all-javahl
check-swig-py
check-swig-rb
check-swig-pl
New issues: None
Known issues: None
GPG signatures committed to the dist/dev/subversion repository.
Re: 1.9.0-rc2 up for testing/signing
Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Sun, May 31, 2015 at 11:28 PM, Ben Reser <be...@reser.org> wrote:
> The 1.9.0-rc2 release artifacts are now available for testing/signing.
> Please get the tarballs from
> https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.
>
Summary:
+1 to release
Platform
Ubuntu 14.04.1 x64, Linux 3.16.0-38-generic SMP
Standard dependencies:
APR 1.5.0
APR-Util 1.5.3
BDB 5.3.28
GCC 4.8.2
httpd 2.4.7, worker MPM
JUnit 4.11
libmagic 5.14
libtool 2.4.2
OpenJDK-7 7u51
OpenSSL 1.0.1f
Perl 5.18.2
Python 2.7.5
Ruby 1.9.3
SQLite 3.8.2
Swig 2.0.11
zlib 1.2.8
Manually installed and in-tree dependencies:
Serf 1.3.8
ctypesgen svn-r151
Verified:
Tarball contents and signatures
(fsfs, bdb, fsx) x (local, svnserve, serf)
check-swig-py
check-swig-pl
check-swig-rb
check-javahl
check-ctypes-python
./get-deps.sh
Results:
All tests passed with one exception:
A non-reproducible failure of diff-test 7 on svn x bdb,
three more runs (all built from scratch) did not show
the problem nor did it show in any other protocol x
backend combination.
Given that tests were run in parallel mode, I suspect
either a test suite fluke or a long-standing issue with
BDB. Neither warrents holding off the release.
GPG Signatures committed to the dist/dev/subversion repository.
-- Stefan^2.
Re: 1.9.0-rc2 up for testing/signing
Posted by Johan Corveleyn <jc...@gmail.com>.
On Sun, May 31, 2015 at 11:28 PM, Ben Reser <be...@reser.org> wrote:
> The 1.9.0-rc2 release artifacts are now available for testing/signing.
> Please get the tarballs from
> https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.
>
> Thanks!
Summary
-------
+1 to release
Platform
--------
Windows 7 SP1 (x64)
Microsoft Visual Studio 2013
Verified
--------
Signature and sha1 for subversion-1.9.0-rc2.zip.
Contents of subversion-1.9.0-rc2.zip are identical to tags/1.9.0-rc2, and
to branches/1.9.x@1682754 (except for expected differences in svn_version.h
and svnpubsub, svnwcsub and nominate.pl (symlinks vs. file contents), and
generated files).
Tested
------
[ Release build ] x [ fsfs ] x [ file | svn | http ]
Results
-------
All tests pass.
Dependencies
------------
Httpd 2.4.12
Apr 1.5.1
Apr-Util 1.5.4
OpenSSL 1.0.2
Serf 1.3.8
SQLite 3.8.8.3
ZLib 1.2.8
Signature
---------
subversion-1.9.0-rc2.zip:
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAABCgAGBQJVdK0OAAoJELWc5tYBDIqt3lYP/1rS07fhgg+3vvgms0e8mXlm
IgdOPNqhKIZkQsSW2TzHvjG5zlp0geSX6VEyHYiHfwxBf9z4nTnjm0aiwGEHhgsU
1tsOz0nqbHQ25ha3I2aQXWi4lZVgcOuLLJn1qD9WTUviMxWwP8ngb/iuhm/FOKoq
fTTSPioZEf4XspbbiornFKNeROZx0rA3whKbmKe2YT3y7pwbggL+ff1uB/Y5OULG
LI3uyfErKZNQkHaUIAoumZIcM/qCQmn8/Z8Ow++RLiE3hMJLADb0XuAfnKv0rX6m
8lbK2XXk1qvq9gC69W9Htfh+eCZaFAa0lWJGeGywQ2PKCuUb/xEVuynx7RIiw5c7
G3CChzRrrYG6IVLiMyWjNez196xuGjsrnd2OuS9q0lQptRnc0liN16Hpl/6hc167
Ygnn0CjiAOQiWXSadpkMtAnmSKWeJwu3Vu/6leSgEraNfZo5OvqzZy+KlZ8cUDcG
Um7yc7z9HBEnfEvttCHCvjKLPzXHOiREKXyWASrrJcQU/OnsdmMNTu3qtttKf+te
a/lktobzdRO3iAxpwBlulQkn4/ICoj/rLCHPDmOkDewZRlDMX94r4TFctvIeGrRr
z1icWd1GEjVEYV5C+gDSdVzEHcXoXoZMs+G5C4Ov9pNZRQ3a7XGtEvFtjBE8bkDT
uul9Kz+L8GQaS6HYYJVN
=6yjY
-----END PGP SIGNATURE-----
--
Johan
Re: 1.9.0-rc2 up for testing/signing
Posted by Stefan Sperling <st...@elego.de>.
On Sun, May 31, 2015 at 02:28:39PM -0700, Ben Reser wrote:
> The 1.9.0-rc2 release artifacts are now available for testing/signing.
> Please get the tarballs from
> https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.
>
> Thanks!
Summary: +1 to release
Tested: [bdb | fsfs] x [ra_local | ra_svn | ra_serf]
swig bindings
javahl bindings
Test results: All passed.
Platform: OpenBSD 5.7 amd64
Dependencies:
bdb: 4.7.25
GNU-iconv: 1.14
apr: 1.5.1
apr-util: 1.5.3
httpd: 2.2.29
serf: 1.3.8
cyrus-sasl: 2.1.25
sqlite: 3080500
openssl: 2.1
swig: 2.0.11
python: 2.7.8
perl: 5.20.2
ruby: 1.8.7-p358
java: 1.7.0_71
Signatures:
subversion-1.9.0-rc2.tar.gz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAABAgAGBQJVbFXdAAoJEE99uqmaWblz+3UH/RaY6+ZzeJ7QA0EbhCQZZiRZ
xAZO+lkryn7iWptfmJhJMUcGxJMc6sX0ob9uhM5DNU24O1h3VtkYy2j6nkDnKe0X
IGBnbUT2RVHtw8BWp2l9Wbda2NWKeiBrAjOpebD7WtJSa3i7O2KdSHMmlHfvLiKx
cHVYb3gUSuXh8TUhWCvpg3LQHWJftJk6qeYb9mTs9fRpVJxOGSvLAHA+HeKtoPDr
Y96VdqLpJOFRuTThk1S79ZoeM5Liz8kshkeOU1atGpGkwZAMSD7I5KpWXd4Xg5C+
WDPYgMXUOX82x1W26UC6jISBPqNDPR0zLNw0Mmsg/dz3246S/ApI+2mzmN7i5wE=
=1Zgw
-----END PGP SIGNATURE-----
subversion-1.9.0-rc2.tar.bz2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAABAgAGBQJVbFXgAAoJEE99uqmaWblzrxEIAM4AFitbeipctTP26+dxxs9s
jE2qS06g1k70Tthorv6yY2Mci97fQIH1J70R8EIO1u9+WZyiWe7ZkakW6eYKHYQ8
01GZxfVFWdDNyMePEdVLRdC4A6OPc3eswxgZPzRYyGFX5Z5Zn/wT2dbQnYVimgJT
TzPaK2uPLpxJtbumo/Xx3hc303q6oV2hgRUxv+JWsbt32eaIXxv9GrqhmmGextAK
8AXqwZvaVMWuTpvdu1bvjvpABMc6E73JNRidKEhgZm5WdyHkv9XS8qVWOd5/uqyr
d0S/jaqloQCmfRUgMjB8F8MKFARGPn2smX9J96omG4lPgNsiZ08lGzHpfjyamMk=
=C8bA
-----END PGP SIGNATURE-----
Re: 1.9.0-rc2 up for testing/signing
Posted by Philip Martin <ph...@wandisco.com>.
Summary:
+1 to release
Platform:
Linux (Debian/jessie) 64-bit
Tested:
(local, svn, svn/sasl, serf, serf/v1) x (fsfs, fsfs/pack/shard, bdb, fsx)
swig-pl, swig-py, swig-rb, ctypes-python
javahl x (fsfs, bdb, fsx)
Results:
FAIL svnadmin_tests.py 32, 33 and 34 with pack/shard due to testsuite bugs
XPASS fs-test 44 due to testsuite bug
All other tests PASS
Local dependencies:
apache2-dev : 2.4.10-10
libapr1-dev : 1.5.1-3
libaprutil1-dev : 1.5.4-1
libdb5.3-dev : 5.3.28-9
libsasl2-dev : 2.1.26.dfsg1-12
libsqlite3-dev : 3.8.7.1-1
perl : 5.20.2-3
python2.7-dev : 2.7.9-2
ruby-dev : 1:2.1.5
openjdk-7-jdk : 7u79-2.5.5-1~deb8u1
serf : 1.3.x@2474
subversion-1.9.0-rc2.tar.bz2
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAABCAAGBQJVcIWeAAoJEHbXiOHtGlmcR+AH/03HWQjiCKUIL5hxSikt1Vbb
vGKGlWjBBsNeH3Iqx6LN7DvDIO/XTuq6K0m5adbSq3BHpj+OMxNHNNzR0f0pyfnv
nviNrzybvGtblEIF4poqniSU+5w6pNmQYDoLOMa8dz8OiYS1eBEKMnSlvKoh96DZ
h+WugyrSgcPE3IPlkcHg+fuMepflh7mvSv1G+EF67xqKBgKNNJMI5/4MOMws9kd+
fNZ5SjklxWeVfQbXfRu8zrhZCmYe4X/AjHxcmfdCFTS2P1GSko4UXVqzetXdMet4
BOkNEs+uoL/wWnlc1AKf0AFSCivLam3dS2m/SCBjoBFtAfVpBBEvjOjS+IiJ/gs=
=Y3e3
-----END PGP SIGNATURE-----
subversion-1.9.0-rc2.tar.gz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQEcBAABCAAGBQJVcIWeAAoJEHbXiOHtGlmctx0H/2DIcZGvbTXz+Z9i9qALnLsQ
vCzf1WLo+vLztykZIpAnODoCstbEu/9e+t7XXyKz4YSFPpj8GQjcxX/O6MgublZV
b5ws+flHFmtnv6p7/hAAzFdVryHrFlbHd8l8oZ8eXKqo9GZlH9/NU9nuwa6wCQuh
7sYgyVuR3W6aJThFLPdToHT0D11OLezOPHTvahZJubM0EXPNnh7WK9WU9pE4wa80
pj1nOXSItmyoBYKzcNEfQQJE0bOCEOnKgK9Rl0aA7GEJx4f+TC6HWPo1wURiAVEn
3D1hqp35nayJa+/RQ2AXCnyVw1AoHVLlLOPEOY9wAxB6TWhdUMs0flp2HRn3I54=
=lFPC
-----END PGP SIGNATURE-----
--
Philip Martin | Subversion Committer
WANdisco // *Non-Stop Data*
Re: 1.9.0-rc2 up for testing/signing
Posted by Branko Čibej <br...@wandisco.com>.
On 03.06.2015 14:57, Ivan Zhakov wrote:
> On 3 June 2015 at 15:35, Branko Čibej <br...@wandisco.com> wrote:
>> On 03.06.2015 14:24, Ivan Zhakov wrote:
>>> On 3 June 2015 at 14:37, Branko Čibej <br...@wandisco.com> wrote:
>>>> On 02.06.2015 20:05, Branko Čibej wrote:
>>>>> On 02.06.2015 12:45, Daniel Shahaf wrote:
>>>>>> Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700:
>>>>>>> The 1.9.0-rc2 release artifacts are now available for testing/signing.
>>>>>>> Please get the tarballs from
>>>>>>> https://dist.apache.org/repos/dist/dev/subversion
>>>>>>> and add your signatures there.
>>>>>>>
>>>>>>> Thanks!
>>>>>> Note that Evgeny reported a regression in svn_repos_verify_fs2() in
>>>>>> <http://svn.haxx.se/dev/archive-2015-05/0141.shtml>. No objections to
>>>>>> moving forward with rc2, but as that issue is a regression, we'll need
>>>>>> an rc3 that fixes it.
>>>>> Yes ... and the patch has been reviewed but not committed. I believe it
>>>>> only needs a couple tweaks (fixing an "if" condition and removing the
>>>>> unused error code).
>>>> I have a more complete fix based on Evgeny's patch, running tests now.
>>>> It turns out that we still need a new error code for the summary
>>>> results, but with a different meaning and therefore different name.
>>>> Renaming it had a positive side effect as it turned out that we were
>>>> emitting the SVN_ERR_REPOS_CORRUPTED error from FSFS and FSX instead of
>>>> the correct SVN_ERR_FS_CORRUPT.
>>>>
>>> Another option would be to require notify_func for
>>> svn_repos_verify_fs3() and always report errors through notify_func.
>>> This would make error reporting consistent whether keep_going TRUE or
>>> FALSE. For svn_repos_verify_fs2() we could create compat notify_func
>>> handler that converts notifications to errors.
>> See r1683311; I believe error reporting is consistent now.
>> Adding complex logic to the deprecated function isn't such a good idea, IMO.
> Maybe, but it's better than adding complex logic to current
> (not-deprecated) function. IMO it's not svn_repos_verify_fs3()
> responsibility to generate verification summary -- it should be done
> at the UI level. I.e. in svnadmin or other application using
> svn_repos_verify_fs3() API.
But that would imply either returning a bunch of extra info from
svn_repos_verify_fs3, or counting notifications in the callers (which
means making the callers depend on implementation details of the API).
Note that the summary will only be generated if an error occurred during
verification in keep-going mode, when we have to return some kind of
error anyway; we may as well put as much info as we have available into
the error message.
-- Brane
Re: 1.9.0-rc2 up for testing/signing
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 3 June 2015 at 15:35, Branko Čibej <br...@wandisco.com> wrote:
> On 03.06.2015 14:24, Ivan Zhakov wrote:
>> On 3 June 2015 at 14:37, Branko Čibej <br...@wandisco.com> wrote:
>>> On 02.06.2015 20:05, Branko Čibej wrote:
>>>> On 02.06.2015 12:45, Daniel Shahaf wrote:
>>>>> Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700:
>>>>>> The 1.9.0-rc2 release artifacts are now available for testing/signing.
>>>>>> Please get the tarballs from
>>>>>> https://dist.apache.org/repos/dist/dev/subversion
>>>>>> and add your signatures there.
>>>>>>
>>>>>> Thanks!
>>>>> Note that Evgeny reported a regression in svn_repos_verify_fs2() in
>>>>> <http://svn.haxx.se/dev/archive-2015-05/0141.shtml>. No objections to
>>>>> moving forward with rc2, but as that issue is a regression, we'll need
>>>>> an rc3 that fixes it.
>>>> Yes ... and the patch has been reviewed but not committed. I believe it
>>>> only needs a couple tweaks (fixing an "if" condition and removing the
>>>> unused error code).
>>> I have a more complete fix based on Evgeny's patch, running tests now.
>>> It turns out that we still need a new error code for the summary
>>> results, but with a different meaning and therefore different name.
>>> Renaming it had a positive side effect as it turned out that we were
>>> emitting the SVN_ERR_REPOS_CORRUPTED error from FSFS and FSX instead of
>>> the correct SVN_ERR_FS_CORRUPT.
>>>
>> Another option would be to require notify_func for
>> svn_repos_verify_fs3() and always report errors through notify_func.
>> This would make error reporting consistent whether keep_going TRUE or
>> FALSE. For svn_repos_verify_fs2() we could create compat notify_func
>> handler that converts notifications to errors.
>
> See r1683311; I believe error reporting is consistent now.
> Adding complex logic to the deprecated function isn't such a good idea, IMO.
Maybe, but it's better than adding complex logic to current
(not-deprecated) function. IMO it's not svn_repos_verify_fs3()
responsibility to generate verification summary -- it should be done
at the UI level. I.e. in svnadmin or other application using
svn_repos_verify_fs3() API.
--
Ivan Zhakov
Re: 1.9.0-rc2 up for testing/signing
Posted by Branko Čibej <br...@wandisco.com>.
On 03.06.2015 14:24, Ivan Zhakov wrote:
> On 3 June 2015 at 14:37, Branko Čibej <br...@wandisco.com> wrote:
>> On 02.06.2015 20:05, Branko Čibej wrote:
>>> On 02.06.2015 12:45, Daniel Shahaf wrote:
>>>> Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700:
>>>>> The 1.9.0-rc2 release artifacts are now available for testing/signing.
>>>>> Please get the tarballs from
>>>>> https://dist.apache.org/repos/dist/dev/subversion
>>>>> and add your signatures there.
>>>>>
>>>>> Thanks!
>>>> Note that Evgeny reported a regression in svn_repos_verify_fs2() in
>>>> <http://svn.haxx.se/dev/archive-2015-05/0141.shtml>. No objections to
>>>> moving forward with rc2, but as that issue is a regression, we'll need
>>>> an rc3 that fixes it.
>>> Yes ... and the patch has been reviewed but not committed. I believe it
>>> only needs a couple tweaks (fixing an "if" condition and removing the
>>> unused error code).
>> I have a more complete fix based on Evgeny's patch, running tests now.
>> It turns out that we still need a new error code for the summary
>> results, but with a different meaning and therefore different name.
>> Renaming it had a positive side effect as it turned out that we were
>> emitting the SVN_ERR_REPOS_CORRUPTED error from FSFS and FSX instead of
>> the correct SVN_ERR_FS_CORRUPT.
>>
> Another option would be to require notify_func for
> svn_repos_verify_fs3() and always report errors through notify_func.
> This would make error reporting consistent whether keep_going TRUE or
> FALSE. For svn_repos_verify_fs2() we could create compat notify_func
> handler that converts notifications to errors.
See r1683311; I believe error reporting is consistent now. Adding
complex logic to the deprecated function isn't such a good idea, IMO.
-- Brane
Re: 1.9.0-rc2 up for testing/signing
Posted by Ivan Zhakov <iv...@visualsvn.com>.
On 3 June 2015 at 14:37, Branko Čibej <br...@wandisco.com> wrote:
> On 02.06.2015 20:05, Branko Čibej wrote:
>> On 02.06.2015 12:45, Daniel Shahaf wrote:
>>> Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700:
>>>> The 1.9.0-rc2 release artifacts are now available for testing/signing.
>>>> Please get the tarballs from
>>>> https://dist.apache.org/repos/dist/dev/subversion
>>>> and add your signatures there.
>>>>
>>>> Thanks!
>>> Note that Evgeny reported a regression in svn_repos_verify_fs2() in
>>> <http://svn.haxx.se/dev/archive-2015-05/0141.shtml>. No objections to
>>> moving forward with rc2, but as that issue is a regression, we'll need
>>> an rc3 that fixes it.
>> Yes ... and the patch has been reviewed but not committed. I believe it
>> only needs a couple tweaks (fixing an "if" condition and removing the
>> unused error code).
>
> I have a more complete fix based on Evgeny's patch, running tests now.
> It turns out that we still need a new error code for the summary
> results, but with a different meaning and therefore different name.
> Renaming it had a positive side effect as it turned out that we were
> emitting the SVN_ERR_REPOS_CORRUPTED error from FSFS and FSX instead of
> the correct SVN_ERR_FS_CORRUPT.
>
Another option would be to require notify_func for
svn_repos_verify_fs3() and always report errors through notify_func.
This would make error reporting consistent whether keep_going TRUE or
FALSE. For svn_repos_verify_fs2() we could create compat notify_func
handler that converts notifications to errors.
--
Ivan Zhakov
Re: 1.9.0-rc2 up for testing/signing
Posted by Branko Čibej <br...@wandisco.com>.
On 02.06.2015 20:05, Branko Čibej wrote:
> On 02.06.2015 12:45, Daniel Shahaf wrote:
>> Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700:
>>> The 1.9.0-rc2 release artifacts are now available for testing/signing.
>>> Please get the tarballs from
>>> https://dist.apache.org/repos/dist/dev/subversion
>>> and add your signatures there.
>>>
>>> Thanks!
>> Note that Evgeny reported a regression in svn_repos_verify_fs2() in
>> <http://svn.haxx.se/dev/archive-2015-05/0141.shtml>. No objections to
>> moving forward with rc2, but as that issue is a regression, we'll need
>> an rc3 that fixes it.
> Yes ... and the patch has been reviewed but not committed. I believe it
> only needs a couple tweaks (fixing an "if" condition and removing the
> unused error code).
I have a more complete fix based on Evgeny's patch, running tests now.
It turns out that we still need a new error code for the summary
results, but with a different meaning and therefore different name.
Renaming it had a positive side effect as it turned out that we were
emitting the SVN_ERR_REPOS_CORRUPTED error from FSFS and FSX instead of
the correct SVN_ERR_FS_CORRUPT.
-- Brane
Re: 1.9.0-rc2 up for testing/signing
Posted by Branko Čibej <br...@wandisco.com>.
On 02.06.2015 12:45, Daniel Shahaf wrote:
> Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700:
>> The 1.9.0-rc2 release artifacts are now available for testing/signing.
>> Please get the tarballs from
>> https://dist.apache.org/repos/dist/dev/subversion
>> and add your signatures there.
>>
>> Thanks!
> Note that Evgeny reported a regression in svn_repos_verify_fs2() in
> <http://svn.haxx.se/dev/archive-2015-05/0141.shtml>. No objections to
> moving forward with rc2, but as that issue is a regression, we'll need
> an rc3 that fixes it.
Yes ... and the patch has been reviewed but not committed. I believe it
only needs a couple tweaks (fixing an "if" condition and removing the
unused error code).
-- Brane
Re: 1.9.0-rc2 up for testing/signing
Posted by Ben Reser <be...@reser.org>.
On 6/2/15 3:45 AM, Daniel Shahaf wrote:
> Note that Evgeny reported a regression in svn_repos_verify_fs2() in
> <http://svn.haxx.se/dev/archive-2015-05/0141.shtml>. No objections to
> moving forward with rc2, but as that issue is a regression, we'll need
> an rc3 that fixes it.
I know I got tired of waiting. rc1 produced valuable feedback. I figure we
haven't lost much if we put out rc2 and put out rc3 with more fixes later, but
we may have gained some more people looking at rc2.
Re: 1.9.0-rc2 up for testing/signing
Posted by Stefan Fuhrmann <st...@wandisco.com>.
On Tue, Jun 2, 2015 at 12:45 PM, Daniel Shahaf <d....@daniel.shahaf.name>
wrote:
> Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700:
> > The 1.9.0-rc2 release artifacts are now available for testing/signing.
> > Please get the tarballs from
> > https://dist.apache.org/repos/dist/dev/subversion
> > and add your signatures there.
> >
> > Thanks!
>
> Note that Evgeny reported a regression in svn_repos_verify_fs2() in
> <http://svn.haxx.se/dev/archive-2015-05/0141.shtml>. No objections to
> moving forward with rc2, but as that issue is a regression, we'll need
> an rc3 that fixes it.
>
The patch has now been committed, reviewed and
approved for 1.9.x.
Apart from changing the API (renamed error code),
this patch is a mere bugfix. Having an RC3 for that
will extend the soak period for 1.9.0 by at most 1 week.
So, there is no point in holding back rc2, which will
restart a full soak period.
-- Stefan^2.
Re: 1.9.0-rc2 up for testing/signing
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Ben Reser wrote on Sun, May 31, 2015 at 14:28:39 -0700:
> The 1.9.0-rc2 release artifacts are now available for testing/signing.
> Please get the tarballs from
> https://dist.apache.org/repos/dist/dev/subversion
> and add your signatures there.
>
> Thanks!
Note that Evgeny reported a regression in svn_repos_verify_fs2() in
<http://svn.haxx.se/dev/archive-2015-05/0141.shtml>. No objections to
moving forward with rc2, but as that issue is a regression, we'll need
an rc3 that fixes it.