You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/22 03:52:55 UTC
[GitHub] [spark] HyukjinKwon commented on a change in pull request #24169:
[SPARK-27235] Remove the Dead code in HashedRelation.scala file from sql
core module
HyukjinKwon commented on a change in pull request #24169: [SPARK-27235] Remove the Dead code in HashedRelation.scala file from sql core module
URL: https://github.com/apache/spark/pull/24169#discussion_r268031059
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
##########
@@ -235,7 +235,7 @@ private[joins] class UnsafeHashedRelation(
0)
val pageSizeBytes = Option(SparkEnv.get).map(_.memoryManager.pageSizeBytes)
- .getOrElse(new SparkConf().getSizeAsBytes("spark.buffer.pageSize", "16m"))
+ .get
Review comment:
What if somehow `SparkEnv` is not initialized yet, and it returns `null`, for instance, test purpose? Looks It would throw `java.util.NoSuchElementException: None.get` after this change. Did you check all the codes paths?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org