[jira] [Comment Edited] (IGNITE-4564) Ensure that builder approach is used for all setters in public API

["Andrew Mashenkov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-4564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833126#comment-15833126 ] 

Andrew Mashenkov edited comment on IGNITE-4564 at 1/21/17 8:03 PM:
-------------------------------------------------------------------

[~vozerov], do you mean configuration classes only should be changed to use this approach or public classes that implementations can be passes to configurations as well (e.g. TcpDiscoverySpi, TcpCommunicationSpi and etc...)?


was (Author: amashenkov):
[~vozerov], do you mean configuration classes only should be changed to use this approach or public classes that implementations can be passes to configurations as well?

> Ensure that builder approach is used for all setters in public API
> ------------------------------------------------------------------
>
>                 Key: IGNITE-4564
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4564
>             Project: Ignite
>          Issue Type: Task
>          Components: general
>    Affects Versions: 1.8
>            Reporter: Vladimir Ozerov
>            Assignee: Andrew Mashenkov
>             Fix For: 2.0
>
>
> *Problem*
> We employed "builder" approach for some configuration classes:
> {code}
> class Configuration {
>     Configuration setSomething(Something);
> }
> {code}
> This is very convenient for users. However, only part of our configs employ this approach.
> *Task*
> Let's make sure that all other parts of our API follow this rule.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)