[GitHub] [pinot] Jackie-Jiang commented on issue #10697: double Nan as default value can massivly expand off heap mutable dictionary

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on issue #10697:
URL: https://github.com/apache/pinot/issues/10697#issuecomment-1526632574

   Good catch. The problem is from `DoubleOffHeapMutableDictionary.equalsValueAt()` which will always return `false` when input `value` is `NaN`.
   We can fix it by comparing the `Double.doubleToLongBits()` (bytes level same), but I'm not sure if allowing `NaN` can cause other problems (it might break the binary search as well). Another option is to prevent `NaN` to be ingested (not allowing it as default value, and also replace it with default value when seeing it in the input data)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org