You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Eric Shu <es...@pivotal.io> on 2017/07/12 17:12:24 UTC

Review Request 60808: GEODE-3178 Fix a flaky JTA test

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60808/
-----------------------------------------------------------

Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, and Nick Reich.


Bugs: GEODE-3178
    https://issues.apache.org/jira/browse/GEODE-3178


Repository: geode


Description
-------

Test now will retry until TX locks are released.


Diffs
-----

  geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java ddf08d0 


Diff: https://reviews.apache.org/r/60808/diff/1/


Testing
-------

UnitTest.


Thanks,

Eric Shu


Re: Review Request 60808: GEODE-3178 Fix a flaky JTA test

Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60808/#review180325
-----------------------------------------------------------




geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java
Lines 107 (patched)
<https://reviews.apache.org/r/60808/#comment255437>

    exceptionLogged?


- anilkumar gingade


On July 12, 2017, 5:12 p.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60808/
> -----------------------------------------------------------
> 
> (Updated July 12, 2017, 5:12 p.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, and Nick Reich.
> 
> 
> Bugs: GEODE-3178
>     https://issues.apache.org/jira/browse/GEODE-3178
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Test now will retry until TX locks are released.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java ddf08d0 
> 
> 
> Diff: https://reviews.apache.org/r/60808/diff/1/
> 
> 
> Testing
> -------
> 
> UnitTest.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>


Re: Review Request 60808: GEODE-3178 Fix a flaky JTA test

Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60808/#review180320
-----------------------------------------------------------


Ship it!




Ship It!

- Darrel Schneider


On July 12, 2017, 10:12 a.m., Eric Shu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60808/
> -----------------------------------------------------------
> 
> (Updated July 12, 2017, 10:12 a.m.)
> 
> 
> Review request for geode, anilkumar gingade, Darrel Schneider, Lynn Gallinat, and Nick Reich.
> 
> 
> Bugs: GEODE-3178
>     https://issues.apache.org/jira/browse/GEODE-3178
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Test now will retry until TX locks are released.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/org/apache/geode/internal/jta/ClientServerJTADUnitTest.java ddf08d0 
> 
> 
> Diff: https://reviews.apache.org/r/60808/diff/1/
> 
> 
> Testing
> -------
> 
> UnitTest.
> 
> 
> Thanks,
> 
> Eric Shu
> 
>