You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/11/16 22:56:38 UTC

[GitHub] [logging-log4cxx] pm-cfs opened a new pull request #43: fix log4cxx mapfilter chaining

pm-cfs opened a new pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43


   # Summary
   Previously we either ACCEPTed or DENYed any log when this filter was present. This configuration prevented proper filter chaining.
   
   # Changes
   * Update mapfilter to return NEUTRAL when additional filters should be considered.
   * Update tests to check for these values.
   
   # Testing
   Run the unit test.
   
   To manually test: using any logging configuration where IP addreses are available in MDC (implementation dependent):
   ```
      <filter class="MapFilter">
         <param name="ip" value="192.169.0.2" />
         <param name="AcceptOnMatch" value="false" />
       </filter>
       <filter class="MapFilter">
         <param name="ip" value="192.169.0.3" />
         <param name="AcceptOnMatch" value="false" />
       </filter>
   ```
   * In the first filter set the IP address to a machine/VM you want to ignore; entries from this machine won't be logged.
   * In the second, change ip address to another machine to ignore.
   * Now verify that the first and second are ignored and a third machine is accepted.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4cxx] rm5248 commented on pull request #43: fix log4cxx mapfilter chaining

Posted by GitBox <gi...@apache.org>.
rm5248 commented on pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43#issuecomment-729248642


   This looks good to me.  I'll merge shortly unless @ams-tschoening has any comments?
   
   Unrelated note: would you be able to create some documentation on how to use the filters, since you use them?  I'm trying to expand the documentation that we do have, but that is a feature that I have never used before, so I don't know where to start.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4cxx] rm5248 commented on pull request #43: fix log4cxx mapfilter chaining

Posted by GitBox <gi...@apache.org>.
rm5248 commented on pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43#issuecomment-729254947


   The Log4j2 documentation would probably be the best place to start: http://logging.apache.org/log4j/2.x/manual/filters.html


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4cxx] pm-cfs commented on pull request #43: fix log4cxx mapfilter chaining

Posted by GitBox <gi...@apache.org>.
pm-cfs commented on pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43#issuecomment-729459747


   I wrote up some MapFilter documentation based on the Log4j2 docs
   formatting. I have it in Google Docs and it exports to PDF ok, but doesn't
   do very well going to Word / RTF. I could also try to export to HTML.
   
   What's the best way to deliver / share it? Do we want to create a docs
   folder and submit as a PR? Will there be a standard template or CMS to
   enter it into?
   
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4cxx] pm-cfs commented on pull request #43: fix log4cxx mapfilter chaining

Posted by GitBox <gi...@apache.org>.
pm-cfs commented on pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43#issuecomment-729249354


   Certainly. I was thinking about that too. I'll have a look at similar
   documentation, but if you know of anything similar off the top of your
   head, please feel free to direct me in an appropriate direction.
   
   -Pat
   
   
   
   Patrick Mills • Principal Software Engineer
   Cerberus, LLC • www.cerberusftp <http://www.cerberusftp.com/>.com
   <http://www.cerberusftp.com/> • patrick.mills@cerberusftp.com
   <al...@cerberusftp.com>
   LinkedIn <https://www.linkedin.com/company/cerberus-ftp/> • Facebook
   <https://www.facebook.com/cerberusftp> • Twitter
   <https://twitter.com/cerberusftp> • Get Support
   <https://www.cerberusftp.com/support/> • Request A Quote
   <https://www.cerberusftp.com/contact/request-a-quote/>
   
   
   On Tue, Nov 17, 2020 at 5:20 PM Robert Middleton <no...@github.com>
   wrote:
   
   > This looks good to me. I'll merge shortly unless @ams-tschoening
   > <https://github.com/ams-tschoening> has any comments?
   >
   > Unrelated note: would you be able to create some documentation on how to
   > use the filters, since you use them? I'm trying to expand the documentation
   > that we do have, but that is a feature that I have never used before, so I
   > don't know where to start.
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/logging-log4cxx/pull/43#issuecomment-729248642>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AOIQ3I2EGRXX2GHHKQHP2SLSQLZJVANCNFSM4TXZU64A>
   > .
   >
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4cxx] ams-tschoening commented on pull request #43: fix log4cxx mapfilter chaining

Posted by GitBox <gi...@apache.org>.
ams-tschoening commented on pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43#issuecomment-729491016


   Have a look at [src\site\markdown](https://github.com/apache/logging-log4cxx/tree/master/src/site/markdown), some `filters.md` there might be a good idea. OTOH, depending on how much you have actually written, providing your docs as APIDOC to the concrete classes might make sense as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4cxx] rm5248 merged pull request #43: fix log4cxx mapfilter chaining

Posted by GitBox <gi...@apache.org>.
rm5248 merged pull request #43:
URL: https://github.com/apache/logging-log4cxx/pull/43


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org