You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/30 06:31:39 UTC
[GitHub] [shardingsphere] zhaojinchao95 opened a new pull request, #21281: Remove overwrite parameter of mode
zhaojinchao95 opened a new pull request, #21281:
URL: https://github.com/apache/shardingsphere/pull/21281
Fixes #20552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] zhaojinchao95 commented on pull request #21281: Remove overwrite parameter of mode
Posted by GitBox <gi...@apache.org>.
zhaojinchao95 commented on PR #21281:
URL: https://github.com/apache/shardingsphere/pull/21281#issuecomment-1263403383
> why remove the `overwrite` config?
@dongzl Hi, we think this parameter is not easy for users to understand and use, and there is another reason to remove it, you can refer to #21066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] dongzl commented on pull request #21281: Remove overwrite parameter of mode
Posted by GitBox <gi...@apache.org>.
dongzl commented on PR #21281:
URL: https://github.com/apache/shardingsphere/pull/21281#issuecomment-1263297818
why remove the `overwrite` config?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #21281: Remove overwrite parameter of mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #21281:
URL: https://github.com/apache/shardingsphere/pull/21281#issuecomment-1263376930
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/21281?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21281](https://codecov.io/gh/apache/shardingsphere/pull/21281?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (05b8783) into [master](https://codecov.io/gh/apache/shardingsphere/commit/51b8c2b6bf5eb52ea4cf463251064c20699aaa35?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (51b8c2b) will **increase** coverage by `0.00%`.
> The diff coverage is `39.13%`.
```diff
@@ Coverage Diff @@
## master #21281 +/- ##
=========================================
Coverage 61.61% 61.62%
Complexity 2555 2555
=========================================
Files 4113 4112 -1
Lines 56708 56670 -38
Branches 7539 7532 -7
=========================================
- Hits 34941 34921 -20
+ Misses 18821 18803 -18
Partials 2946 2946
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/21281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/yaml/config/pojo/mode/YamlModeConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9wb2pvL21vZGUvWWFtbE1vZGVDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
| [...mespace/parser/DataSourceBeanDefinitionParser.java](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLXNwcmluZy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUtc3ByaW5nL3NoYXJkaW5nc3BoZXJlLWpkYmMtY29yZS1zcHJpbmctbmFtZXNwYWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zcHJpbmcvbmFtZXNwYWNlL3BhcnNlci9EYXRhU291cmNlQmVhbkRlZmluaXRpb25QYXJzZXIuamF2YQ==) | `87.50% <ø> (-0.60%)` | :arrow_down: |
| [...vice/config/database/DataSourcePersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL2NvbmZpZy9kYXRhYmFzZS9EYXRhU291cmNlUGVyc2lzdFNlcnZpY2UuamF2YQ==) | `56.66% <0.00%> (ø)` | |
| [...ce/config/database/DatabaseRulePersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL2NvbmZpZy9kYXRhYmFzZS9EYXRhYmFzZVJ1bGVQZXJzaXN0U2VydmljZS5qYXZh) | `23.80% <0.00%> (ø)` | |
| [...ervice/config/global/GlobalRulePersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL2NvbmZpZy9nbG9iYWwvR2xvYmFsUnVsZVBlcnNpc3RTZXJ2aWNlLmphdmE=) | `23.07% <0.00%> (-4.20%)` | :arrow_down: |
| [...ervice/config/global/PropertiesPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL21vZGUvbWV0YWRhdGEvcGVyc2lzdC9zZXJ2aWNlL2NvbmZpZy9nbG9iYWwvUHJvcGVydGllc1BlcnNpc3RTZXJ2aWNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../manager/cluster/ClusterContextManagerBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9DbHVzdGVyQ29udGV4dE1hbmFnZXJCdWlsZGVyLmphdmE=) | `69.56% <0.00%> (ø)` | |
| [...tsql/ral/UpdatableGlobalRuleRALBackendHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL1VwZGF0YWJsZUdsb2JhbFJ1bGVSQUxCYWNrZW5kSGFuZGxlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...dler/distsql/ral/updatable/SetVariableHandler.java](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL3VwZGF0YWJsZS9TZXRWYXJpYWJsZUhhbmRsZXIuamF2YQ==) | `80.55% <0.00%> (ø)` | |
| [...fig/swapper/mode/YamlModeConfigurationSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS95YW1sL2NvbmZpZy9zd2FwcGVyL21vZGUvWWFtbE1vZGVDb25maWd1cmF0aW9uU3dhcHBlci5qYXZh) | `45.45% <50.00%> (-4.55%)` | :arrow_down: |
| ... and [173 more](https://codecov.io/gh/apache/shardingsphere/pull/21281/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #21281: Remove overwrite parameter of mode
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #21281:
URL: https://github.com/apache/shardingsphere/pull/21281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org