You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/10 08:46:56 UTC

[GitHub] [flink] KarmaGYZ opened a new pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

KarmaGYZ opened a new pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361
 
 
   …ters in one call
   
   
   ## What is the purpose of the change
   
   Let BashJavaUtils return dynamic configs and JVM parameters in one call.
   
   ## Brief change log
   
   Let BashJavaUtils return dynamic configs and JVM parameters in one call. The second last line of output is JVM parameters and the last line is dynamic configs.
   
   ## Verifying this change
   
   This change is already covered by tests: BashJavaUtilsITCase
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: yes
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#issuecomment-596976998
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152594634",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6212",
       "triggerID" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/152919016",
       "triggerID" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cd09736f8968ac04c685e0bd502a18bd163388bf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152594634) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116) 
   * 1ffc375e2b14f76c86e56d6d7aa888094a45d475 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/152919016) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6212) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#issuecomment-596976998
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152594634",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cd09736f8968ac04c685e0bd502a18bd163388bf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152594634) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#discussion_r390925037
 
 

 ##########
 File path: flink-dist/src/main/flink-bin/bin/taskmanager.sh
 ##########
 @@ -48,8 +48,9 @@ if [[ $STARTSTOP == "start" ]] || [[ $STARTSTOP == "start-foreground" ]]; then
 
     # Startup parameters
 
-    jvm_params_output=`runBashJavaUtilsCmd GET_TM_RESOURCE_JVM_PARAMS ${FLINK_CONF_DIR}`
-    jvm_params=`extractExecutionParams "$jvm_params_output"`
+    params_output=$(runBashJavaUtilsCmd GET_TM_RESOURCE_PARAMS ${FLINK_CONF_DIR} | tail -n 2)
+
+    jvm_params=$(extractExecutionParams "$(echo "$params_output" | tail -n 2 | head -n 1)")
 
 Review comment:
   `head -n 1` should be sufficient since `params_output` already only contains 2 lines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#issuecomment-596970074
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit cd09736f8968ac04c685e0bd502a18bd163388bf (Tue Mar 10 08:48:54 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#issuecomment-596976998
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cd09736f8968ac04c685e0bd502a18bd163388bf UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#issuecomment-597986864
 
 
   Thanks for the review @zentol . PR updated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#discussion_r391510520
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/BashJavaUtils.java
 ##########
 @@ -74,13 +70,8 @@ private static Configuration getConfigurationForStandaloneTaskManagers(String[]
 	 */
 	public enum Command {
 		/**
-		 * Get dynamic configs of task executor resources.
-		 */
-		GET_TM_RESOURCE_DYNAMIC_CONFIGS,
-
-		/**
-		 * Get JVM parameters of task executor resources.
+		 * Get JVM parameters and dynamic configs of task executor resources.
 		 */
-		GET_TM_RESOURCE_JVM_PARAMS
+		GET_TM_RESOURCE_PARAMS
 
 Review comment:
   If this were to happen we'd revert back to having to call it multiple times; we'd likely just print another line instead, no?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#discussion_r391571017
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/BashJavaUtils.java
 ##########
 @@ -74,13 +70,8 @@ private static Configuration getConfigurationForStandaloneTaskManagers(String[]
 	 */
 	public enum Command {
 		/**
-		 * Get dynamic configs of task executor resources.
-		 */
-		GET_TM_RESOURCE_DYNAMIC_CONFIGS,
-
-		/**
-		 * Get JVM parameters of task executor resources.
+		 * Get JVM parameters and dynamic configs of task executor resources.
 		 */
-		GET_TM_RESOURCE_JVM_PARAMS
+		GET_TM_RESOURCE_PARAMS
 
 Review comment:
   I think we merge the two command here because they are all used in the same place when tm starts. However, the scope of this class is utility for bash. Commands added in future might be called anywhere. In that case, I think it's not just appending another line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#issuecomment-596976998
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152594634",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cd09736f8968ac04c685e0bd502a18bd163388bf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152594634) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116) 
   * 1ffc375e2b14f76c86e56d6d7aa888094a45d475 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#discussion_r390925321
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/BashJavaUtils.java
 ##########
 @@ -74,13 +70,8 @@ private static Configuration getConfigurationForStandaloneTaskManagers(String[]
 	 */
 	public enum Command {
 		/**
-		 * Get dynamic configs of task executor resources.
-		 */
-		GET_TM_RESOURCE_DYNAMIC_CONFIGS,
-
-		/**
-		 * Get JVM parameters of task executor resources.
+		 * Get JVM parameters and dynamic configs of task executor resources.
 		 */
-		GET_TM_RESOURCE_JVM_PARAMS
+		GET_TM_RESOURCE_PARAMS
 
 Review comment:
   we could just remove the concept of commands.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#issuecomment-596976998
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152594634",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cd09736f8968ac04c685e0bd502a18bd163388bf Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/152594634) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] KarmaGYZ commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
KarmaGYZ commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#discussion_r391364036
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/util/BashJavaUtils.java
 ##########
 @@ -74,13 +70,8 @@ private static Configuration getConfigurationForStandaloneTaskManagers(String[]
 	 */
 	public enum Command {
 		/**
-		 * Get dynamic configs of task executor resources.
-		 */
-		GET_TM_RESOURCE_DYNAMIC_CONFIGS,
-
-		/**
-		 * Get JVM parameters of task executor resources.
+		 * Get JVM parameters and dynamic configs of task executor resources.
 		 */
-		GET_TM_RESOURCE_JVM_PARAMS
+		GET_TM_RESOURCE_PARAMS
 
 Review comment:
   I prefer to keep it in case we add other utility functions in this class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#issuecomment-596976998
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152594634",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * cd09736f8968ac04c685e0bd502a18bd163388bf Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/152594634) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol merged pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#discussion_r390924124
 
 

 ##########
 File path: flink-dist/src/test/bin/runBashJavaUtilsCmd.sh
 ##########
 @@ -36,5 +36,6 @@ FLINK_DIST_JAR=`find $FLINK_TARGET_DIR -name 'flink-dist*.jar'`
 
 . ${bin}/../../main/flink-bin/bin/config.sh > /dev/null
 
-output=`runBashJavaUtilsCmd ${COMMAND} ${FLINK_CONF_DIR} "$FLINK_TARGET_DIR/bash-java-utils.jar:$FLINK_DIST_JAR}"`
-extractExecutionParams "$output"
+output=$(runBashJavaUtilsCmd GET_TM_RESOURCE_PARAMS ${FLINK_CONF_DIR} "$FLINK_TARGET_DIR/bash-java-utils.jar:$FLINK_DIST_JAR}" | tail -n 2)
+extractExecutionParams "$(echo "$output" | tail -n 2 | head -n 1)"
 
 Review comment:
   `head -n 1` should be sufficient since `output` already only contains 2 lines.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#issuecomment-596976998
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152594634",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6212",
       "triggerID" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/152919016",
       "triggerID" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1ffc375e2b14f76c86e56d6d7aa888094a45d475 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/152919016) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6212) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#issuecomment-596976998
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "DELETED",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/152594634",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6116",
       "triggerID" : "cd09736f8968ac04c685e0bd502a18bd163388bf",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6212",
       "triggerID" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "triggerType" : "PUSH"
     }, {
       "hash" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/152919016",
       "triggerID" : "1ffc375e2b14f76c86e56d6d7aa888094a45d475",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 1ffc375e2b14f76c86e56d6d7aa888094a45d475 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/152919016) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6212) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…

Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #11361: [FLINK-15727] Let BashJavaUtils return dynamic configs and JVM parame…
URL: https://github.com/apache/flink/pull/11361#discussion_r390928769
 
 

 ##########
 File path: flink-dist/src/test/java/org/apache/flink/dist/BashJavaUtilsITCase.java
 ##########
 @@ -36,32 +37,13 @@
 
 	private static final String RUN_BASH_JAVA_UTILS_CMD_SCRIPT = "src/test/bin/runBashJavaUtilsCmd.sh";
 
-	/**
-	 * Executes the given shell script wrapper and returns the last line.
-	 */
-	private String executeScriptAndFetchLastLine(final String command) throws IOException {
-		String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, command};
-		String[] lines = executeScript(commands).split(System.lineSeparator());
-		if (lines.length == 0) {
-			return "";
-		} else {
-			return lines[lines.length - 1];
-		}
-	}
-
-	@Test
-	public void testGetTmResourceDynamicConfigs() throws Exception {
-		String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_DYNAMIC_CONFIGS.toString());
-
-		assertNotNull(result);
-		ConfigurationUtils.parseTmResourceDynamicConfigs(result);
-	}
-
 	@Test
-	public void testGetTmResourceJvmParams() throws Exception {
-		String result = executeScriptAndFetchLastLine(BashJavaUtils.Command.GET_TM_RESOURCE_JVM_PARAMS.toString());
+	public void testGetTmResourceParamsConfigs() throws Exception {
+		String[] commands = {RUN_BASH_JAVA_UTILS_CMD_SCRIPT, BashJavaUtils.Command.GET_TM_RESOURCE_PARAMS.toString()};
+		List<String> lines = Arrays.asList(executeScript(commands).split(System.lineSeparator()));
 
-		assertNotNull(result);
-		ConfigurationUtils.parseTmResourceJvmParams(result);
+		assertTrue(lines.size() >= 2);
 
 Review comment:
   shouldn't this be _exactly_ 2 lines? (and if so, use assertEquals)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services