You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "TherChenYang (via GitHub)" <gi...@apache.org> on 2024/02/27 06:57:14 UTC

[PR] Adjust parser, rewrite the module positions in the document. [shardingsphere]

TherChenYang opened a new pull request, #30314:
URL: https://github.com/apache/shardingsphere/pull/30314

   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
     - Adjust parser, rewrite the module positions in the document.
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [x] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Adjust parser, rewrite the module positions in the document. [shardingsphere]

Posted by "TherChenYang (via GitHub)" <gi...@apache.org>.
TherChenYang commented on code in PR #30314:
URL: https://github.com/apache/shardingsphere/pull/30314#discussion_r1503928244


##########
docs/document/content/test-manual/module-test/parser-test.cn.md:
##########
@@ -9,11 +9,11 @@ SQL 解析无需真实的测试环境,开发者只需定义好待测试的 SQL
 
 ### SQL数据
 
-在集成测试的部分提到过 `sql-case-id`,其对应的 SQL,可以在不同模块共享。开发者只需要在 `shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql/supported/${SQL-TYPE}/*.xml` 添加待测试的 SQL 即可。
+在集成测试的部分提到过 `sql-case-id`,其对应的 SQL,可以在不同模块共享。开发者只需要在`shardingsphere-sql-parser-test`模块中添加待测试的 SQL 即可,位置位于`test/it/parser/src/main/resources/sql/supported/${SQL-TYPE}/*.xml` 。

Review Comment:
   Thank you very much for your correction. I did have some problems copying it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Adjust parser, rewrite the module positions in the document. [shardingsphere]

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang commented on code in PR #30314:
URL: https://github.com/apache/shardingsphere/pull/30314#discussion_r1503898828


##########
docs/document/content/test-manual/module-test/parser-test.cn.md:
##########
@@ -9,11 +9,11 @@ SQL 解析无需真实的测试环境,开发者只需定义好待测试的 SQL
 
 ### SQL数据
 
-在集成测试的部分提到过 `sql-case-id`,其对应的 SQL,可以在不同模块共享。开发者只需要在 `shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql/supported/${SQL-TYPE}/*.xml` 添加待测试的 SQL 即可。
+在集成测试的部分提到过 `sql-case-id`,其对应的 SQL,可以在不同模块共享。开发者只需要在`shardingsphere-sql-parser-test`模块中添加待测试的 SQL 即可,位置位于`test/it/parser/src/main/resources/sql/supported/${SQL-TYPE}/*.xml` 。

Review Comment:
   Hi @TherChenYang 
   The module name may be not `shardingsphere-sql-parser-test`, please check it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Adjust parser, rewrite the module positions in the document. [shardingsphere]

Posted by "TherChenYang (via GitHub)" <gi...@apache.org>.
TherChenYang commented on code in PR #30314:
URL: https://github.com/apache/shardingsphere/pull/30314#discussion_r1503938813


##########
docs/document/content/test-manual/module-test/parser-test.cn.md:
##########
@@ -9,11 +9,11 @@ SQL 解析无需真实的测试环境,开发者只需定义好待测试的 SQL
 
 ### SQL数据
 
-在集成测试的部分提到过 `sql-case-id`,其对应的 SQL,可以在不同模块共享。开发者只需要在 `shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql/supported/${SQL-TYPE}/*.xml` 添加待测试的 SQL 即可。
+在集成测试的部分提到过 `sql-case-id`,其对应的 SQL,可以在不同模块共享。开发者只需要在`shardingsphere-sql-parser-test`模块中添加待测试的 SQL 即可,位置位于`test/it/parser/src/main/resources/sql/supported/${SQL-TYPE}/*.xml` 。

Review Comment:
   @RaigorJiang Thank you for your correction, I have made the adjustment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Adjust parser, rewrite the module positions in the document. [shardingsphere]

Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #30314:
URL: https://github.com/apache/shardingsphere/pull/30314


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org