You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/01 03:12:25 UTC

[GitHub] [apisix] zaunist commented on issue #5812: feat: support to use plugin_config_id for Service

zaunist commented on issue #5812:
URL: https://github.com/apache/apisix/issues/5812#issuecomment-1085369785


   Hi, community.
   
   Is this feature still needed？If so, I would like to complete this feature. But I have some questions about the development of this feature, can anyone give me some guidelines?
   
   I checked our code and I found that the merge method of plugin_config only supports route, not service.
   https://github.com/apache/apisix/blob/c9ce0362fc5201295c73398db2d50d32c9197462/apisix/plugin_config.lua#L48
   
   My questions are as follows:
   
   - Should we use the existing `merge` method be modified to support both `service` and `route`, or code a new method, such as `merge_service`, be added to support the merging of plugin_config in service.
   - Do I need to come up with a proposal for this feature support?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org